Inlining of map and set and detection when they are used - #159
Merged
Conversation
lolleko
reviewed
Jul 28, 2018
| return result; | ||
| } | ||
|
|
||
| public checkForLuaLibType(type: ts.Type): void { |
Member
There was a problem hiding this comment.
The naming of this function seems a bit of to me. As it checks for the time, but also adds the feature.
lolleko
approved these changes
Jul 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect when Map and Set are used and inline them.
Set test lualibimport to "require" by default.
Require now only adds the require statement if any lualib features are detected.
Added an "always" option for luaLibImport to always add the require to the lualib bundle.
Also some general fixes to the lualib imports and inlining.
Closes #154.
Fixes an issue with inlining order as mentioned in #155.