Skip to content

Fixed bug where table.unpack was called in Lua 5.1 - #141

Closed
osyrisrblx wants to merge 4 commits into
TypeScriptToLua:masterfrom
osyrisrblx:tstl-master
Closed

Fixed bug where table.unpack was called in Lua 5.1#141
osyrisrblx wants to merge 4 commits into
TypeScriptToLua:masterfrom
osyrisrblx:tstl-master

Conversation

@osyrisrblx

Copy link
Copy Markdown

No description provided.

@Perryvw Perryvw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some tests pls

Comment thread .vscode/settings.json Outdated
@@ -0,0 +1,15 @@
{

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't commit this file.

@Perryvw

Perryvw commented Jul 12, 2018

Copy link
Copy Markdown
Member

Yes, if you look at expressions.spec.ts you will find a whole bunch of version specific tests:
https://github.com/Perryvw/TypescriptToLua/blob/master/test/unit/expressions.spec.ts#L108-L172

Merge Perryvw/TypescriptToLua
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants