Version split - #117
Merged
Merged
Conversation
Perryvw
approved these changes
Jun 7, 2018
dmarcuse
reviewed
Jun 7, 2018
|
|
||
| export class LuaTranspiler { | ||
| export abstract class LuaTranspiler { | ||
| public static AvailableLuaTargets = [LuaTarget.LuaJIT, LuaTarget.Lua53]; |
Contributor
There was a problem hiding this comment.
This isn't needed any more
Member
Author
There was a problem hiding this comment.
It prevents the class from being instantiated.
|
|
||
| import * as ts from "typescript"; | ||
|
|
||
| export class LuaTranspiler52 extends LuaTranspiler { |
Contributor
There was a problem hiding this comment.
Lua 5.2 added the bit32 library, this could be used to implement bit operations
Member
Author
There was a problem hiding this comment.
Sure, but we should probably do that in a different PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #116