Fixes bundle mode with enabled sourceMapTraceback#1110
Merged
Conversation
- Join code chunk, due to its correctness and existness
Perryvw
requested changes
Aug 30, 2021
Perryvw
left a comment
Member
There was a problem hiding this comment.
Would expect to see at least one test added to verify this actually fixes the problem.
Contributor
Author
Main changes
Misc changes
Tests coverage
|
sanikoyes
pushed a commit
to sanikoyes/TypeScriptToLua
that referenced
this pull request
Sep 24, 2021
* TypeScriptToLua#1109 In Progress - Join code chunk, due to its correctness and existness * Removed unused `sourceMapNode` * Provided SourceMapTraceBack for bundled files (TypeScriptToLua#1109) * Moved helpful function `lineAndColumnOf` into utils.ts file * Covered bundling with source map traceback (TypeScriptToLua#1109) * Removed unnecessary comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1109 for details