Deprecated @tupleReturn and various lualib improvements#1075
Merged
Conversation
sanikoyes
pushed a commit
to sanikoyes/TypeScriptToLua
that referenced
this pull request
Sep 24, 2021
…Lua#1075) * Add test for lualib dependencies and refactor tupleReturn/multiReturn * Deprecated @tupleReturn * No longer add not needed tostring calls to string += statements * upgrade lua-types version to one without @tupleReturn * Fix linter and make execution not fail when there are only warning diagnostics * Fix benchmark code for new lua-types * Disable benchmark workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces any tupleReturn checks with LuaMultiReturn checks, and LuaMultiReturn checks fall back on tupleReturn until support for this annotation is removed. It adds a warning that @tupleReturn is about to be removed.
Also adds a test that checks if lualib functions have the correct dependencies set, to avoid lualib inlining bugs. Also cleaned up tests a bit.
Also optimizes some weird lua I noticed in our lualib:
[a, b] = [c, d]now translates toa, b = c, dinstead ofa, b = __TS__Unpack({ c, d})str1 += v.toString()now translates tostr1 .. tostring(v)instead oftostring(str1) .. tostring(tostring(v))