Conversation
Member
Author
|
Woops, putting this back into draft after realising I forgot the case where |
Member
Author
Problem solved. |
lolleko
reviewed
Aug 11, 2021
# Conflicts: # src/LuaLib.ts # src/lualib/declarations/global.d.ts
tomblind
reviewed
Aug 17, 2021
tomblind
left a comment
Collaborator
There was a problem hiding this comment.
One thing I don't see represented in the tests is direct chaining:
promise.then(...).then(...).catch(...)
It might be good to test this to ensure these calls are returning the correct thing.
|
|
||
| util.testFunction` | ||
| // Wrap function getUserData(id: number, callback: (userData: UserData) => void) into a Promise | ||
| async function getUserDataAsync(id: number): Promise<UserData> { |
Collaborator
There was a problem hiding this comment.
dumb question: how does this work if we don't support async yet?
Member
Author
There was a problem hiding this comment.
It works because async keyword has no special function yet and will just be ignored. You are right that this is a a strange async, and in fact I think it is removed again in my async/await branch. I will remove it here too.
lolleko
reviewed
Aug 17, 2021
| ` | ||
| .setTsHeader(promiseTestLib) | ||
| .expectToEqual(["finally"]); | ||
| }); |
Member
There was a problem hiding this comment.
Maybe another test for finally that checks that this:
myPromise
.then(response => {
doSomething(response);
runFinalCode();
})
.catch(e => {
returnError(e);
runFinalCode();
});is equivalent to this:
myPromise
.then(response => {
doSomething(response);
})
.catch(e => {
returnError(e);
})
.finally(() => {
runFinalCode();
});Can possibly be implemented like this:
const { noThrow, noThrowResolve } = defer<string>();
const { throw_, throwResolve } = defer<string>();
noThrow.then(
data => { log(data); log("finally"); }
)
.catch(
e => { log(e); log("finally"); }
);
throw_.then(
data => { throw data; log("finally"); }
)
.catch(
e => { log(e); log("finally"); }
);
noThrowResolve("test");
throwResolve("test");
const { finallyNoThrow, finallyNoThrowResolve } = defer<string>();
const { finallyThrow, finallyThrowResolve } = defer<string>();
finallyNoThrow.then(
data => { log(data); }
)
.catch(
e => { log(e); }
)
.finally(
() => { log("finally"); }
);
finallyThrow.then(
data => { throw data; }
)
.catch(
e => { log(e); }
)
.finally(
() => { log("finally"); }
);
finallyNoThrow("test");
finallyThrow("test");
return allLogs;
// expectToEqual(["test", "finally", "test", "finally", "test", "finally", "test", "finally"])
lolleko
approved these changes
Aug 17, 2021
tomblind
approved these changes
Aug 18, 2021
sanikoyes
pushed a commit
to sanikoyes/TypeScriptToLua
that referenced
this pull request
Sep 24, 2021
* Initial lualib promise class implementation * First promise tests * More promise tests * Promise class implementation * Implemented Promise.all * Promise.any * Promise.race * Promise.allSettled * fix prettier * Add promise example usage test * Added missing lualib dependencies for PromiseConstructor functions * Immediately call then/catch/finally callbacks on promises that are already resolved * Transform all references to Promise to __TS__Promise * PR feedback * Removed incorrect asyncs * Add test for direct chaining * Add test for finally and correct wrong behavior it caught * Added test throwing in parallel and chained then onFulfilleds * Fixed pull request link in ArrayIsArray lualib comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Out of scope: async/await, will be done in follow-up PR
Implemented promises based on https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise and a little bit of https://promisesaplus.com/
Note: For now we are deviating from the spec in an important aspect: currently the promise constructor function is executed immediately, instead of waiting until there is no more user code on stack, like the promise spec mandates.