Fixed major bug with varargs/spread operator - #100
Merged
Conversation
Merge in fixes for access to namespace members
Member
|
Looks good if you remove the failing "undefined tests" and make a separate PR/Issue for them, we can merge this. |
lolleko
approved these changes
Apr 26, 2018
Contributor
Author
|
I had to grapple with git to undo those changes, I wasn't aware that the new commit would be appended to this pull request. I'm certain it's safe to merge now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bug because usage of the spread operator transpiled without error into Lua, where the varargs array would be transpiled into only the first value of the varags; see here.
Closes #95