Skip to content

fix-39: Adding new block removes last character #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewlipski merged 5 commits into from
Feb 8, 2023
Merged

fix-39: Adding new block removes last character #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
89c4c30
fix-39: Adding new block remove last character
sudarshanshenoy Dec 27, 2022
d44ad83
Minor change and added test
matthewlipski Feb 8, 2023
a442dcb
Merge branch 'main' into fix-39-newblock-removes-last-char
matthewlipski Feb 8, 2023
12ed24c
Moved changes to `DraggableBlocksPlugin.ts`
matthewlipski Feb 8, 2023
948031e
Updated test snapshots
matthewlipski Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/core/src/extensions/DraggableBlocks/DraggableBlocksPlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,8 @@ export class BlockMenuView {
.BNUpdateBlock(newBlockContentPos, { type: "paragraph", props: {} })
.setTextSelection(newBlockContentPos)
.run();
} else {
this.editor.commands.setTextSelection(endPos);
}

// Focuses and activates the suggestion menu.
Expand Down
8 changes: 8 additions & 0 deletions tests/end-to-end/draghandle/draghandle.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,14 @@ test.describe("Check Draghandle functionality", () => {
await page.waitForSelector(DRAG_HANDLE_ADD_SELECTOR, { state: "detached" });
});

test("Click add button for non-selected empty block", async () => {
await executeSlashCommand(page, "h1");
await page.keyboard.type("Heading 1");
await hoverAndAddBlockFromDragHandle(page, PARAGRAPH_SELECTOR, "h1");

await compareDocToSnapshot(page, "addnonselectedemptyblock");
});

test("Clicking delete button should delete block", async () => {
await executeSlashCommand(page, "h1");
await page.keyboard.type("Hover over this text");
Expand Down
66 changes: 66 additions & 0 deletions ...-end/draghandle/draghandle.test.ts-snapshots/addnonselectedemptyblock-chromium-linux.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
{
"type": "doc",
"content": [
{
"type": "blockGroup",
"content": [
{
"type": "blockContainer",
"attrs": {
"id": 0,
"textColor": "default",
"backgroundColor": "default"
},
"content": [
{
"type": "heading",
"attrs": {
"textAlignment": "left",
"level": "1"
},
"content": [
{
"type": "text",
"text": "Heading 1"
}
]
}
]
},
{
"type": "blockContainer",
"attrs": {
"id": 1,
"textColor": "default",
"backgroundColor": "default"
},
"content": [
{
"type": "heading",
"attrs": {
"textAlignment": "left",
"level": "1"
}
}
]
},
{
"type": "blockContainer",
"attrs": {
"id": 2,
"textColor": "default",
"backgroundColor": "default"
},
"content": [
{
"type": "paragraph",
"attrs": {
"textAlignment": "left"
}
}
]
}
]
}
]
}
66 changes: 66 additions & 0 deletions ...o-end/draghandle/draghandle.test.ts-snapshots/addnonselectedemptyblock-firefox-linux.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
{
"type": "doc",
"content": [
{
"type": "blockGroup",
"content": [
{
"type": "blockContainer",
"attrs": {
"id": 0,
"textColor": "default",
"backgroundColor": "default"
},
"content": [
{
"type": "heading",
"attrs": {
"textAlignment": "left",
"level": "1"
},
"content": [
{
"type": "text",
"text": "Heading 1"
}
]
}
]
},
{
"type": "blockContainer",
"attrs": {
"id": 1,
"textColor": "default",
"backgroundColor": "default"
},
"content": [
{
"type": "heading",
"attrs": {
"textAlignment": "left",
"level": "1"
}
}
]
},
{
"type": "blockContainer",
"attrs": {
"id": 2,
"textColor": "default",
"backgroundColor": "default"
},
"content": [
{
"type": "paragraph",
"attrs": {
"textAlignment": "left"
}
}
]
}
]
}
]
}
66 changes: 66 additions & 0 deletions ...to-end/draghandle/draghandle.test.ts-snapshots/addnonselectedemptyblock-webkit-linux.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
{
"type": "doc",
"content": [
{
"type": "blockGroup",
"content": [
{
"type": "blockContainer",
"attrs": {
"id": 0,
"textColor": "default",
"backgroundColor": "default"
},
"content": [
{
"type": "heading",
"attrs": {
"textAlignment": "left",
"level": "1"
},
"content": [
{
"type": "text",
"text": "Heading 1"
}
]
}
]
},
{
"type": "blockContainer",
"attrs": {
"id": 1,
"textColor": "default",
"backgroundColor": "default"
},
"content": [
{
"type": "heading",
"attrs": {
"textAlignment": "left",
"level": "1"
}
}
]
},
{
"type": "blockContainer",
"attrs": {
"id": 2,
"textColor": "default",
"backgroundColor": "default"
},
"content": [
{
"type": "paragraph",
"attrs": {
"textAlignment": "left"
}
}
]
}
]
}
]
}