BNSplitBlock fix#72
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Collaborator
|
Nice, is there a test for this as well? |
# Conflicts: # packages/core/src/extensions/Blocks/nodes/BlockContainer.ts
fogle
pushed a commit
to fogle/BlockNote
that referenced
this pull request
May 20, 2023
* Fixed block splitting bug * Rewrite to use `Slice` instead of `textContent` for block content * Minor changes * Added related keyboard handler tests * Updated Chromium snapshot * Increased test timeout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the
BNSplitBlockfunction only copies text content to the new block, if the block being split has nested blocks, they aren't preserved and their text is just concatenated together. This PR fixes the issue, and now usesSplitobjects to replace content in both the original and new block, whereas before they were only used for the original block.