fix: Formatting toolbar appearance on fade out#642
Closed
matthewlipski wants to merge 1 commit into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Collaborator
Author
|
Fixed with #645 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because formatting toolbar buttons manage their own state, they check whether they should be shown based on the block that the text cursor is in. This can be a problem if the user clicks a block of a different type to close the toolbar, as it can cause the toolbar state to change as it's fading out, which looks bad. This PR fixes that by making the plugin figure out which block(s) are selected instead, and including them in the plugin state for the toolbar buttons.
The difference between this approach and using
useSelectedBlocksis that the plugin will NOT update the selected blocks ifstate.showisfalse, so the selected blocks are only updated when the formatting toolbar itself is shown/updated.This is similar to how & why we pass the hovered block in the side menu/drag handle menu, so I think this pattern makes sense.