fix: Mantine styles#553
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1 task
YousefED
approved these changes
Jan 31, 2024
Collaborator
YousefED
left a comment
There was a problem hiding this comment.
Approve, but I don't think it closes #546 definitively. We should open an issue with Mantine and:
- explain clearly what the issue is and what the impact is (many people running into it)
- propose a solution (quick brainstorm, there might be better options; like splitting the css to an optional file, or making the root container where it's applied to configurable?)
rockiger
approved these changes
Jan 31, 2024
rockiger
left a comment
There was a problem hiding this comment.
Works as a workaround. But why not override all global styles from Mantine?
Collaborator
Author
|
Changed it to this solution: https://github.com/orgs/mantinedev/discussions/5685 |
rockiger
approved these changes
Feb 1, 2024
YousefED
reviewed
Feb 1, 2024
YousefED
reviewed
Feb 1, 2024
|
This solution was merged into v0.11.2 but in that version I'm still having the issue. I just tried BlockNote first time (v0.11.2) and now my styles are messed up. I also tried updating my app mantine version from v7.3.2 to v7.5.1 with no luck Edit: |
matthewlipski
added a commit
that referenced
this pull request
Feb 13, 2024
* fix: Docs home page demo styling fix (#507) * Fixed styling for code styles (#517) * Made suggestions plugin control multiple menus * Added hook to create suggestion menu * Fixed add block button behaviour on blocks with different content (#526) * Small CSS fix (#527) * fix: List item shortcuts (#528) * Fixed list item shortcuts * Updated test screenshots * Added code toggle formatting toolbar example (#531) * fix: Errors when hovering image block while editor is uneditable (#533) * Fixed errors when hovering image block while editor is uneditable * Small fix * fix: Formatting toolbar not hiding while dragging blocks (#529) * Fixed formatting toolbar not hiding while dragging blocks * Small fix * Updated Mantine (#535) * Updated `package-lock.json` (#536) * v0.11.1 * v0.6.2 * v0.8.1 * v0.8.2 * v0.8.3 * v0.8.4 * v0.8.5 * v0.9.0 * v0.9.1 * Revert "v0.9.1" This reverts commit 6e9d61f. * v0.9.1 * Revert "v0.9.1" This reverts commit ac7abee. * v0.9.2 * v0.9.3 * v0.9.4 * v0.9.5 * v0.9.6 * v0.10.0 * v0.10.1 * v0.11.0 * v0.11.1 * fix collaboration and editable: false bug (#538) * pair refactoring * wip * fix type annotations on some of the docs (#539) * Cleanup and continue refactor * docs: Dark mode styling fix (#548) * Fixed styles that were overwritten by Mantine globals * Removed old code * Implemented PR feedback * Add Liveblocks info and BlockNote download command (#540) * Update real-time-collaboration.md * feat: Example image * feat: Replace image with video * Fixed video --------- Co-authored-by: Matthew Lipski <matthewlipski@gmail.com> * Implemented PR feedback * fix: Mantine styles (#553) * Updated Mantine and package-lock * Added Mantine global styles reset * Made Mantine global styles not get imported * Fixed CSS import order * Updated test & snapshots * Implemented PR feedback * Implemented PR feedback * Fixed paragraph shortcut (#556) * v0.11.2 * Fixed build issues * Fixed add block button behaviour * Small fix * Small fix * Fixed tests --------- Co-authored-by: Yousef <yousefdardiry@gmail.com> Co-authored-by: Chris Nicholas <ctnicholasdev@gmail.com>
matthewlipski
added a commit
that referenced
this pull request
Mar 5, 2024
* Added async slash menu items POC * Fixed vanilla example * Small test fix * Implemented PR feedback * Improved performance * Simplified how outdated queries are ignored/cancelled * small fixes * Added custom suggestion menus PoC * Updated custom mentions example * Add Liveblocks info and BlockNote download command (#540) * Update real-time-collaboration.md * feat: Example image * feat: Replace image with video * Fixed video --------- Co-authored-by: Matthew Lipski <matthewlipski@gmail.com> * wip: migrate to nextjs * update docs2 * fixes * fix: Mantine styles (#553) * Updated Mantine and package-lock * Added Mantine global styles reset * Made Mantine global styles not get imported * Fixed CSS import order * Updated test & snapshots * Implemented PR feedback * Implemented PR feedback * Fixed paragraph shortcut (#556) * v0.11.2 * fix * fix index * Converted more examples & small fixes * Added gen files for new examples * Small typing fixes * misc * fix build * disable examples * Converted remaining examples and small fixes * improve examples * react icon import only types * fix build speed * Fixed demo & examples styling * Small fix * basic auth working * remove old site * clean script + organize examples * Changed home page gradients and styling fixes * update examples, docs, scripts * fix playground * fix docs * fix playground * add strictmode again! * Revert "add strictmode again!" This reverts commit 692c5b3. * Revised features section and gradients * small fixes * small fixes * small fixes * try fix link clicks + speed * fix type issue * Revised styles, fixed dark mode, and small cleanup * Small fix * Improved dark mode selection * Refactor/cleanup mount system (#567) * cleanup mount system * demo * wip * fix build * fix * fix light / dark mode * clean examples * clean examples * docs * misc * refs * better errors * add default block / partialblock types * wip: examples * fix theme * update interop examples * Small fixes --------- Co-authored-by: Matthew Lipski <matthewlipski@gmail.com> * refactor: Mentions & custom suggestion menus (#534) * fix: Docs home page demo styling fix (#507) * Fixed styling for code styles (#517) * Made suggestions plugin control multiple menus * Added hook to create suggestion menu * Fixed add block button behaviour on blocks with different content (#526) * Small CSS fix (#527) * fix: List item shortcuts (#528) * Fixed list item shortcuts * Updated test screenshots * Added code toggle formatting toolbar example (#531) * fix: Errors when hovering image block while editor is uneditable (#533) * Fixed errors when hovering image block while editor is uneditable * Small fix * fix: Formatting toolbar not hiding while dragging blocks (#529) * Fixed formatting toolbar not hiding while dragging blocks * Small fix * Updated Mantine (#535) * Updated `package-lock.json` (#536) * v0.11.1 * v0.6.2 * v0.8.1 * v0.8.2 * v0.8.3 * v0.8.4 * v0.8.5 * v0.9.0 * v0.9.1 * Revert "v0.9.1" This reverts commit 6e9d61f. * v0.9.1 * Revert "v0.9.1" This reverts commit ac7abee. * v0.9.2 * v0.9.3 * v0.9.4 * v0.9.5 * v0.9.6 * v0.10.0 * v0.10.1 * v0.11.0 * v0.11.1 * fix collaboration and editable: false bug (#538) * pair refactoring * wip * fix type annotations on some of the docs (#539) * Cleanup and continue refactor * docs: Dark mode styling fix (#548) * Fixed styles that were overwritten by Mantine globals * Removed old code * Implemented PR feedback * Add Liveblocks info and BlockNote download command (#540) * Update real-time-collaboration.md * feat: Example image * feat: Replace image with video * Fixed video --------- Co-authored-by: Matthew Lipski <matthewlipski@gmail.com> * Implemented PR feedback * fix: Mantine styles (#553) * Updated Mantine and package-lock * Added Mantine global styles reset * Made Mantine global styles not get imported * Fixed CSS import order * Updated test & snapshots * Implemented PR feedback * Implemented PR feedback * Fixed paragraph shortcut (#556) * v0.11.2 * Fixed build issues * Fixed add block button behaviour * Small fix * Small fix * Fixed tests --------- Co-authored-by: Yousef <yousefdardiry@gmail.com> Co-authored-by: Chris Nicholas <ctnicholasdev@gmail.com> * Refactored how remaining UI elements (except table handles) are created to match suggestions * remove file left after merge * Replaced `data`/`position` hooks with refactored general hooks * Fixed vanilla example * Lint fix * Minor fixes * Refactored table handles * clean getitems * misc * test * tests * small fixes * about page * Implemented PR feedback * Small naming fix * Added vanilla default slash menu items * address feedback * pair work * add footer * small fix * faq, sponsors * noteplan * readme todo * Cleaned up homepage * Addressed docs TODOs and cleanup * refactor: UI component types, names, and API (#584) * Cleaned up UI components and examples * Continued cleanup * Continued cleanup * Continued cleanup * Imlemented PR feedback * add default onItemClick * Implemented PR feedback * Small fix * fix build * remove file * Rename * fix image caption button * Moved components requiring Mantine to `/mantine` directories * Small fix * Updated formatting toolbar & side menu docs * suggestion (#588) * suggestion * Fixed block type dropdown API and small refactor --------- Co-authored-by: Matthew Lipski <matthewlipski@gmail.com> * Added hyperlink toolbar docs and small changes * Updated slash menu docs & small fixes * Updated slash menu docs & small fixes * wip * update scripts * fix * fix * remove files * fix * update names * small fixes * docs * as discussed * address comments * Added initial content to UI component examples & small changes * Cleaned up UI component docs * custom schemas + custom blocks page * fix * update slash menu docs * move some examples * rename slash menu to suggestion menu * Added custom inline content page and other fixes * fix * theming todos * Made discussed changes to styling & theming docs * address feedback * Added custom styles docs * Fixed theming & styling demos * Updated advanced docs * docs: Proposal for editor basics docs changes (#594) * Added proposals for editor basics docs changes * Addressed editor basics TODOs * fix build * fix * Updated editor api links * generate + clean some comments * fix? * disable og * docs review (#596) * docs review * Fixed PR feedback --------- Co-authored-by: Matthew Lipski <matthewlipski@gmail.com> --------- Co-authored-by: yousefed <yousefdardiry@gmail.com> --------- Co-authored-by: yousefed <yousefdardiry@gmail.com> * Fixed demo styles & windows scrollbars * fix build * fix og image? * Changed selections demo(s) & fixed various styles * fix lint * lint fix * Fixed demo input/output TODOs and removed hide last line hack * fix tests * try fix tests * Updated e2e test setup * Updated e2e test setup * Added docs pages redirects and misc changes * scripts * Updated screenshots * Fixed various docs TODOs * webpack stats / github ci * WIP: Fix/polish examples * ci update * Finished examples cleanup (expect collab) * Fixed toolbar button click behaviour for Safari * Fixed collaboration examples * Revert dependency changes * fix package json * separate inter font * fix xss #601 * Implemented PR feedback * small edits * small cleanup * fix bugs * features (wip) * fix * only apply fix to safari * comments * fix package lock * fix authors * fix bug * fix inline content api * Added insert inline content docs * update docs * small fixes * update readme * text * feat: Editor option to customize placeholders (#503) * Added option to customize placeholders * Slightly adjusted default placeholders * check emptyness with css * Added editor options to customize placeholders via CSS * Implemented PR feedback * small placeholder fixes --------- Co-authored-by: yousefed <yousefdardiry@gmail.com> * fix Incorrect blocknote styles affecting Mantine ToolTip component styles #566 * export * Cleaned up home page code * Added font import --------- Co-authored-by: Matthew Lipski <matthewlipski@gmail.com> Co-authored-by: Chris Nicholas <ctnicholasdev@gmail.com> Co-authored-by: Matthew Lipski <50169049+matthewlipski@users.noreply.github.com>
matthewlipski
added a commit
that referenced
this pull request
Mar 5, 2024
* first step * update examples * remove veaury * upgrade sandpack * example test * tests * misc * update vite configs * misc fixes * add docs * add comments * Added async slash menu items POC * Fixed vanilla example * Small test fix * Implemented PR feedback * Improved performance * Simplified how outdated queries are ignored/cancelled * small fixes * Added custom suggestion menus PoC * Updated custom mentions example * remove beta * fix settings * Added remaining examples * Build fixes and removed generated playground/docs files * Small fixes * fix build * re-add generated files * small fixes * wip: migrate to nextjs * update docs2 * fixes * fix * fix index * Converted more examples & small fixes * Added gen files for new examples * Small typing fixes * misc * fix build * disable examples * Converted remaining examples and small fixes * improve examples * react icon import only types * fix build speed * Fixed demo & examples styling * Small fix * basic auth working * remove old site * clean script + organize examples * Changed home page gradients and styling fixes * update examples, docs, scripts * fix playground * fix docs * fix playground * add strictmode again! * Revert "add strictmode again!" This reverts commit 692c5b3. * Revised features section and gradients * small fixes * small fixes * small fixes * try fix link clicks + speed * fix type issue * Revised styles, fixed dark mode, and small cleanup * Small fix * Improved dark mode selection * Refactor/cleanup mount system (#567) * cleanup mount system * demo * wip * fix build * fix * fix light / dark mode * clean examples * clean examples * docs * misc * refs * better errors * add default block / partialblock types * wip: examples * fix theme * update interop examples * Small fixes --------- Co-authored-by: Matthew Lipski <matthewlipski@gmail.com> * refactor: Mentions & custom suggestion menus (#534) * fix: Docs home page demo styling fix (#507) * Fixed styling for code styles (#517) * Made suggestions plugin control multiple menus * Added hook to create suggestion menu * Fixed add block button behaviour on blocks with different content (#526) * Small CSS fix (#527) * fix: List item shortcuts (#528) * Fixed list item shortcuts * Updated test screenshots * Added code toggle formatting toolbar example (#531) * fix: Errors when hovering image block while editor is uneditable (#533) * Fixed errors when hovering image block while editor is uneditable * Small fix * fix: Formatting toolbar not hiding while dragging blocks (#529) * Fixed formatting toolbar not hiding while dragging blocks * Small fix * Updated Mantine (#535) * Updated `package-lock.json` (#536) * v0.11.1 * v0.6.2 * v0.8.1 * v0.8.2 * v0.8.3 * v0.8.4 * v0.8.5 * v0.9.0 * v0.9.1 * Revert "v0.9.1" This reverts commit 6e9d61f. * v0.9.1 * Revert "v0.9.1" This reverts commit ac7abee. * v0.9.2 * v0.9.3 * v0.9.4 * v0.9.5 * v0.9.6 * v0.10.0 * v0.10.1 * v0.11.0 * v0.11.1 * fix collaboration and editable: false bug (#538) * pair refactoring * wip * fix type annotations on some of the docs (#539) * Cleanup and continue refactor * docs: Dark mode styling fix (#548) * Fixed styles that were overwritten by Mantine globals * Removed old code * Implemented PR feedback * Add Liveblocks info and BlockNote download command (#540) * Update real-time-collaboration.md * feat: Example image * feat: Replace image with video * Fixed video --------- Co-authored-by: Matthew Lipski <matthewlipski@gmail.com> * Implemented PR feedback * fix: Mantine styles (#553) * Updated Mantine and package-lock * Added Mantine global styles reset * Made Mantine global styles not get imported * Fixed CSS import order * Updated test & snapshots * Implemented PR feedback * Implemented PR feedback * Fixed paragraph shortcut (#556) * v0.11.2 * Fixed build issues * Fixed add block button behaviour * Small fix * Small fix * Fixed tests --------- Co-authored-by: Yousef <yousefdardiry@gmail.com> Co-authored-by: Chris Nicholas <ctnicholasdev@gmail.com> * Refactored how remaining UI elements (except table handles) are created to match suggestions * remove file left after merge * Replaced `data`/`position` hooks with refactored general hooks * Fixed vanilla example * Lint fix * Minor fixes * Refactored table handles * clean getitems * misc * test * tests * small fixes * about page * Implemented PR feedback * Small naming fix * Added vanilla default slash menu items * address feedback * pair work * add footer * small fix * faq, sponsors * noteplan * readme todo * Cleaned up homepage * Addressed docs TODOs and cleanup * refactor: UI component types, names, and API (#584) * Cleaned up UI components and examples * Continued cleanup * Continued cleanup * Continued cleanup * Imlemented PR feedback * add default onItemClick * Implemented PR feedback * Small fix * fix build * remove file * Rename * fix image caption button * Moved components requiring Mantine to `/mantine` directories * Small fix * Updated formatting toolbar & side menu docs * suggestion (#588) * suggestion * Fixed block type dropdown API and small refactor --------- Co-authored-by: Matthew Lipski <matthewlipski@gmail.com> * Added hyperlink toolbar docs and small changes * Updated slash menu docs & small fixes * Updated slash menu docs & small fixes * wip * update scripts * fix * fix * remove files * fix * update names * small fixes * docs * as discussed * address comments * Added initial content to UI component examples & small changes * Cleaned up UI component docs * custom schemas + custom blocks page * fix * update slash menu docs * move some examples * rename slash menu to suggestion menu * Added custom inline content page and other fixes * fix * theming todos * Made discussed changes to styling & theming docs * address feedback * Added custom styles docs * Fixed theming & styling demos * Updated advanced docs * docs: Proposal for editor basics docs changes (#594) * Added proposals for editor basics docs changes * Addressed editor basics TODOs * fix build * fix * Updated editor api links * generate + clean some comments * fix? * disable og * docs review (#596) * docs review * Fixed PR feedback --------- Co-authored-by: Matthew Lipski <matthewlipski@gmail.com> --------- Co-authored-by: yousefed <yousefdardiry@gmail.com> --------- Co-authored-by: yousefed <yousefdardiry@gmail.com> * Fixed demo styles & windows scrollbars * fix build * fix og image? * Changed selections demo(s) & fixed various styles * fix lint * lint fix * Fixed demo input/output TODOs and removed hide last line hack * fix tests * try fix tests * Updated e2e test setup * Updated e2e test setup * Added docs pages redirects and misc changes * scripts * Updated screenshots * Fixed various docs TODOs * webpack stats / github ci * WIP: Fix/polish examples * ci update * Finished examples cleanup (expect collab) * Fixed toolbar button click behaviour for Safari * Fixed collaboration examples * Revert dependency changes * fix package json * separate inter font * fix xss #601 * Implemented PR feedback * small edits * small cleanup * fix bugs * features (wip) * fix * only apply fix to safari * comments * fix package lock * fix authors * fix bug * fix inline content api * Added insert inline content docs * update docs * small fixes * update readme * text * feat: Editor option to customize placeholders (#503) * Added option to customize placeholders * Slightly adjusted default placeholders * check emptyness with css * Added editor options to customize placeholders via CSS * Implemented PR feedback * small placeholder fixes --------- Co-authored-by: yousefed <yousefdardiry@gmail.com> * fix Incorrect blocknote styles affecting Mantine ToolTip component styles #566 * export * Cleaned up home page code * Added font import * update about * Implemented community/faq feedback * Updated test screenshots * Updated features gifs * Removed TODOs (added corresponding GH issues) * Fixed link --------- Co-authored-by: yousefed <yousefdardiry@gmail.com> Co-authored-by: Chris Nicholas <ctnicholasdev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating Mantine did not get rid of all of the global styles it sets, which are still causing issues. So it seems like it is a better alternative to just reset them, as it doesn't seem that the Mantine team is going to change this anytime soon (https://discord.com/channels/854810300876062770/1193507663020032060).
This PR also fixes loaders being rendered inside
ActionIconcomponents:Closes #549 #546