Repository navigation
fix(core): keep the formatting toolbar hidden when focus returns to editor UI - #3187
Merged
Merged
Conversation
…ditor UI When focus came back from outside the editor into its UI (e.g. the drag handle), the toolbar showed again for the old selection, over the drag handle menu. Show it again only when the content area has focus. Closes #3186
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly and concisely describes the main change: keeping the formatting toolbar hidden when focus returns to editor UI. |
| Description check | |
The description explains the problem, root cause, fix, affected behavior, linked issue, and regression test coverage. It omits several template sections, including Impact, Screenshots/Video, Checklist… |
| Linked Issues check | |
Issue #3186 requires the formatting toolbar to remain hidden when the editor content has lost focus and the drag-handle menu opens. FormattingToolbar.ts now calls shouldShow() on focus return only… |
| Out of Scope Changes check | |
The source change is limited to focus-based formatting-toolbar visibility. The added end-to-end test covers the #3186 regression. The import changes support that test. No unrelated implementation or t… |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2… |
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit watched the toolbar hide,
Then checked the editor’s focus inside.
The drag handle opened; the menu stayed clear,
No toolbar returned to hover near.
The rabbit thumped: “That test is dear!”
Comment @coderabbitai help to get the list of available commands.
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/diagram-block
@blocknote/mantine
@blocknote/math-block
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
@blocknote/xl-typst-exporter
commit: |
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3186
Problem
The editor has a selection, and focus is outside the editor. The user clicks a drag handle. The formatting toolbar shows again, over the drag handle menu.
The focus handler from #3031 counts the editor's UI as part of the editor. Focus that moves from outside onto the drag handle shows the toolbar for the old selection.
Fix
When focus comes back, show the toolbar only if the content area has focus (
editor.isFocused()). Thepointeruphandler in the same file already uses this check.Tests
New test in
draghandle.test.tsx: select text, move focus outside the editor, click a drag handle. The toolbar must stay hidden. The test fails without the fix in chromium, firefox and webkit.Summary by CodeRabbit