Skip to content

fix: Text cursor flicker in trailing block #2839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthewlipski wants to merge 1 commit into
base: main
Choose a base branch
from
+34 −1
Open

fix: Text cursor flicker in trailing block #2839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/core/src/editor/Block.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ BASIC STYLES
.bn-trailing-block {
cursor: text;
height: 30px;
user-select: none;
}

/*
Expand Down
34 changes: 33 additions & 1 deletion packages/core/src/extensions/TrailingNode/TrailingNode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
import type { Node as PMNode } from "prosemirror-model";
import { Plugin, PluginKey, type Transaction } from "prosemirror-state";
import {
Plugin,
PluginKey,
Selection,
type Transaction,
} from "prosemirror-state";
import { Decoration, DecorationSet } from "prosemirror-view";
import {
createExtension,
Expand Down Expand Up @@ -127,6 +132,33 @@ export const TrailingNodeExtension = createExtension(
},
props: {
decorations: (state) => PLUGIN_KEY.getState(state),
// Prevents ProseMirror from trying to move the selection into the
// trailing block, which causes the text caret to flicker in it
// before returning to its previous position.
handleKeyDown: (view, event) => {
if (event.key !== "ArrowRight" && event.key !== "ArrowDown") {
return false;
}

const { selection } = view.state;
if (!selection.empty) {
return false;
}

const docEnd = Selection.atEnd(view.state.doc);
if (selection.$head.pos !== docEnd.$head.pos) {
return false;
}

if (
!shouldShowTrailingWidget(view.state.doc, editor.isEditable)
) {
return false;
}

event.preventDefault();
return true;
},
},
}),
],
Expand Down
Loading