fix: Side menu height table (BLO-1117)#2837
Open
matthewlipski wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📝 WalkthroughWalkthroughCSS rule added to constrain the side menu height to 60px specifically for table block types. A new selector ChangesTable Side Menu Styling
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/react/src/editor/styles.css (1)
287-289: 💤 Low valueConsider adding a comment to explain the height value.
Adding a brief comment explaining that 60px aligns with the table's first row height would improve maintainability, similar to the comment at line 258.
📝 Suggested comment
+/* Matches Side Menu height to first table row */ .bn-side-menu[data-block-type="table"] { height: 60px; }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/react/src/editor/styles.css` around lines 287 - 289, Add a one-line comment above the .bn-side-menu[data-block-type="table"] rule explaining that height: 60px matches the table's first row height (so the side menu aligns visually with the first row), mirroring the explanatory style used for the similar rule at the other table-related selector; reference the selector .bn-side-menu[data-block-type="table"] and the height: 60px value in the comment.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/react/src/editor/styles.css`:
- Around line 287-289: Add a one-line comment above the
.bn-side-menu[data-block-type="table"] rule explaining that height: 60px matches
the table's first row height (so the side menu aligns visually with the first
row), mirroring the explanatory style used for the similar rule at the other
table-related selector; reference the selector
.bn-side-menu[data-block-type="table"] and the height: 60px value in the
comment.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d889c711-6553-4a98-b2db-2e7ff88ae3b9
📒 Files selected for processing (1)
packages/react/src/editor/styles.css
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the side menu slightly taller when next to table blocks, so that it's aligned with the first row.
Closes #2604
Rationale
This is a minor visual improvement.
Changes
Impact
N/A
Testing
N/A (imo too minor to warrant a visual regression test)
Screenshots/Video
N/A
Checklist
Additional Notes
N/A
Summary by CodeRabbit