feat(tables): add the ability to enable/disable table features#1470
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
matthewlipski
approved these changes
Feb 28, 2025
Collaborator
matthewlipski
left a comment
There was a problem hiding this comment.
Looks good! Just 1 question
| /** | ||
| * Allows enabling / disabling features of tables. | ||
| */ | ||
| tables?: { |
Collaborator
There was a problem hiding this comment.
Does it make sense putting tables under a settings option? Having both seems a bit redundant, or are you also thinking of adding/moving other stuff to the settings option in the future?
Contributor
Author
There was a problem hiding this comment.
I was thinking that we'd have more settings in the future, so it made sense to namespace it. But, I'm open to the suggestion of a flat-list. I just feel like it often gets namespaced anyway
nperez0111
commented
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new option to the editor instance
settingswhich is for editor specific configuration that we want our UI to be reactive to.For now, it only implements enabling and disabling specific table functionality that may be too much for certain applications. Now, you can use this settings to enable the ability to use those features