Skip to content

fix: add editor parameter to inline content render (core) #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewlipski merged 2 commits into from
Sep 20, 2024
Merged

fix: add editor parameter to inline content render (core) #1091

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
969dc95
add editor parameter to inline content render (core)
YousefED Sep 20, 2024
5467f24
Fixed lint issue
matthewlipski Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions packages/core/src/schema/inlineContent/createSpec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import {
inlineContentToNodes,
nodeToCustomInlineContent,
} from "../../api/nodeConversions/nodeConversions";
import type { BlockNoteEditor } from "../../editor/BlockNoteEditor";
import { propsToAttributes } from "../blocks/internal";
import { Props } from "../propTypes";
import { StyleSchema } from "../styles/types";
Expand Down Expand Up @@ -34,13 +35,13 @@ export type CustomInlineContentImplementation<
inlineContent: InlineContentFromConfig<T, S>,
updateInlineContent: (
update: PartialCustomInlineContentFromConfig<T, S>
) => void
) => void,
/**
* The BlockNote editor instance
* This is typed generically. If you want an editor with your custom schema, you need to
* cast it manually, e.g.: `const e = editor as BlockNoteEditor<typeof mySchema>;`
*/
// editor: BlockNoteEditor<B, I, S>
editor: BlockNoteEditor<any, any, S>
// (note) if we want to fix the manual cast, we need to prevent circular references and separate block definition and render implementations
// or allow manually passing <BSchema>, but that's not possible without passing the other generics because Typescript doesn't support partial inferred generics
) => {
Expand Down Expand Up @@ -109,7 +110,8 @@ export function createInlineContentSpec<
) as any as InlineContentFromConfig<T, S>, // TODO: fix cast
() => {
// No-op
}
},
editor
);

return addInlineContentAttributes(
Expand Down Expand Up @@ -148,7 +150,8 @@ export function createInlineContentSpec<
content
)
);
}
},
editor
);

return addInlineContentAttributes(
Expand Down