This repository was archived by the owner on Jul 1, 2026. It is now read-only.
Upgrade node-pre-gyp to version 0.9.0 - #952
Merged
Merged
Conversation
Contributor
Author
|
@springmeyer The OS X NODE_VERSION="5" COVERAGE=true PUBLISHABLE=false job failed. This error has already occurred before this pull request. build/temp.macosx-10.12-intel-2.7/_openssl.c:493:10: fatal error: 'openssl/opensslv.h' file not found
#include <openssl/opensslv.h>
^
1 error generated.
error: Setup script exited with error: command 'cc' failed with exit status 1
The command "if [[ ${COVERAGE} == true ]]; then if [[ $(uname -s) == 'Linux' ]]; then PYTHONUSERBASE=$(pwd)/py-local pip install --user cpp-coveralls; else PYTHONUSERBASE=$(pwd)/py-local easy_install --user cpp-coveralls; fi; fi" failed and exited with 1 during . |
Contributor
|
Yes, that is safe to ignore/unrelated to your PR. Thanks for providing this, merging now. |
|
Awesome fellas :) |
This was referenced Mar 16, 2018
theone74
pushed a commit
to theone74/node-sqlite3
that referenced
this pull request
Jun 1, 2018
Upgrade node-pre-gyp to version 0.9.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #950