Skip to content
This repository was archived by the owner on Jul 1, 2026. It is now read-only.

Fix OPTIONAL_ARGUMENT_FUNCTION - #755

Closed
fanatid wants to merge 1 commit into
TryGhost:masterfrom
fanatid:patch-2
Closed

Fix OPTIONAL_ARGUMENT_FUNCTION#755
fanatid wants to merge 1 commit into
TryGhost:masterfrom
fanatid:patch-2

Conversation

@fanatid

@fanatid fanatid commented Dec 25, 2016

Copy link
Copy Markdown

No description provided.

@springmeyer

Copy link
Copy Markdown
Contributor

Can you explain why this was/is needed?

@fanatid

fanatid commented Jun 23, 2018

Copy link
Copy Markdown
Author

I think it was done because rest of macros had this.
Right now, I'm not sure what was requirements for, but I believe that wrap any macros argument to parentheses is good practice.

@fanatid
fanatid deleted the patch-2 branch June 23, 2018 15:39
@springmeyer

Copy link
Copy Markdown
Contributor

Thanks. I'll keep close as this will change with N-API: #79

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants