Skip to content
This repository was archived by the owner on Jul 1, 2026. It is now read-only.

sqlite3 update to 3.35.2 (3350200) - #1457

Closed
charlesj wants to merge 1 commit into
TryGhost:masterfrom
charlesj:master
Closed

sqlite3 update to 3.35.2 (3350200)#1457
charlesj wants to merge 1 commit into
TryGhost:masterfrom
charlesj:master

Conversation

@charlesj

Copy link
Copy Markdown

3.35 adds several nice new features, including returning

@border-radius

Copy link
Copy Markdown

Tested this brunch locally, all tests passed:

  161 passing (29s)

Can anyone trigger travis-ci to rerun tests?

@border-radius

Copy link
Copy Markdown

Hmm, forked your fork and installed in my project:

npm i border-radius/node-sqlite3 --save

Tried this query:

db.get('INSERT INTO invites (token) VALUES (?) RETURNING *', [token], (e, row) => {
  //...
})

But still getting this error:

Error: SQLITE_ERROR: near "RETURNING": syntax error

🤔

@mscdex

mscdex commented Jun 14, 2021

Copy link
Copy Markdown
Contributor

@border-radius You might want to double check that node-pre-gyp isn't installing/using a prebuilt/precompiled addon for your platform. Try adding --build-from-source to your npm installation command line to ensure that's not the case.

@rustyconover

Copy link
Copy Markdown

Any updates on this merge?

@johan13

johan13 commented Jun 28, 2021

Copy link
Copy Markdown

I am looking forward to getting this merged!

Since this PR was opened there has been a few bug fixes. Maybe we should try to get 3.35.5 merged instead?

@Glowin

Glowin commented Jul 3, 2021

Copy link
Copy Markdown
Contributor

@johan13 Any update of sqlite3 latest version? the latest version is 3.36.0 now. https://www.sqlite.org/releaselog/3_36_0.html

@johan13

johan13 commented Jul 4, 2021

Copy link
Copy Markdown

@johan13 Any update of sqlite3 latest version? the latest version is 3.36.0 now. https://www.sqlite.org/releaselog/3_36_0.html

No, I never got around to that. Thanks for submitting #1476. Let's hope it receives more attention from the maintainers than this PR did.

@kewde

kewde commented Oct 8, 2021

Copy link
Copy Markdown
Collaborator

Thank you for your contribution, but a newer version was merged.

@kewde kewde closed this Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants