This repository was archived by the owner on Jul 1, 2026. It is now read-only.
Support SmartOS builds - #114
Closed
mcavage wants to merge 1 commit into
Closed
Conversation
Author
|
Oh - forgot to mention, the binding.gyp change is SmartOS only - mac/linux/... will all still use the path you were using already. |
|
I have also experienced this issue. |
|
This patch also makes it work again on nodejitsu.com. I copied this changed file on top of the current git version: panzi@ff1dc49 |
Contributor
|
new tag: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I tried to use your module, but it does not compile on SmartOS as your sqlite3 dependency results in an empty archive. However, on SmartOS it makes more sense to just pick up sqlite from pkgsrc anyway, as that's going to be a known good build.
This change is simply to make binding.gyp look for sqlite to already be on the system, and link against that.
Sadly, I am unable to run
make testas expresso relies on jscoverage, which also doesn't compile on SmartOS.FWW, I've had better luck with cover anyway, as it's (1) pure JS, and (2) only does coverage; I tend to use either node-tap or nodeunit as they are less magical than expresso/mocha. That said, the library seems to work.
m