🎨 decrease timeout for scheduling#7556
Merged
ErisDS merged 1 commit intoTryGhost:masterfrom Oct 13, 2016
Merged
Conversation
refs TryGhost#7555 - temporary fix to make travis green - that should not have a any bad effect on scheduling - we just let the job awake a bit later - the job logic is strong enough to catch the job if setTimeout awakes too late (that can happen, because setTimeout is not accurate) - if (moment().diff(moment(Number(timestamp))) <= self.beforePingInMs) --> is smaller ensures that even if the diff is negative, it get's executed
mixonic
pushed a commit
to mixonic/Ghost
that referenced
this pull request
Oct 28, 2016
refs TryGhost#7555 - temporary fix to make travis green - that should not have a any bad effect on scheduling - we just let the job awake a bit later - the job logic is strong enough to catch the job if setTimeout awakes too late (that can happen, because setTimeout is not accurate) - if (moment().diff(moment(Number(timestamp))) <= self.beforePingInMs) --> is smaller ensures that even if the diff is negative, it get's executed
geekhuyang
pushed a commit
to geekhuyang/Ghost
that referenced
this pull request
Nov 20, 2016
refs TryGhost#7555 - temporary fix to make travis green - that should not have a any bad effect on scheduling - we just let the job awake a bit later - the job logic is strong enough to catch the job if setTimeout awakes too late (that can happen, because setTimeout is not accurate) - if (moment().diff(moment(Number(timestamp))) <= self.beforePingInMs) --> is smaller ensures that even if the diff is negative, it get's executed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs #7555
Since Node v6.8.0 (was released today), tests start to fail for scheduling.
Node made some improvements for
setImmediate, see nodejs/node#8655.Either we mis-use Node, or Node has introduced a bug.
This is a temporary fix only to make travis green!!!
if (moment().diff(moment(Number(timestamp))) <= self.beforePingInMs)