Skip to content

Core/BattlePets: Fix nicknamed companion pets showing their species name - #32078

Open
Oreocide wants to merge 1 commit into
TrinityCore:masterfrom
Oreocide:pr/battle-pet-nickname-timestamp
Open

Oreocide wants to merge 1 commit into
TrinityCore:masterfrom
Oreocide:pr/battle-pet-nickname-timestamp

Conversation

@Oreocide

Copy link
Copy Markdown

Summary

  • The client only requests a companion's custom name when the name timestamp on the summoned unit is not 0, so a nicknamed battle pet showed its species name above its head.
  • Battle pets that have a nickname but no stored timestamp now get one when they are loaded.

Test plan

  • Summon a battle pet that has a nickname and confirm the nickname shows above its head instead of the species name.
  • Rename a summoned battle pet and confirm the new name shows without resummoning.

The client only requests a companion's custom name when the name timestamp on the summoned unit is not 0. Give battle pets that have a nickname but no stored timestamp one when they are loaded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant