Repository navigation
Conversation
Boarding stripped the ride aura and ran the mammoth goodbye, and the client dropped the board spline when it arrived with the spawn. Player mounts also kept the vehicle record's no-jump and no-strafe flags after dismount. The Mighty Caravan Brutosaur and Trader's Gilded Brutosaur spells still name the White Stallion, so mounts 1039 and 2265 now use the ceremonial howdah vehicle. Merchant Maku's stock is included. Vehicle 6372 keeps howdah seats but uses mammoth locomotion flags so strafing turns onto the diagonal.
OnAuraRemoved calls TempSummon::GetSummonerUnit for the mammoth vendors. Clang needs the full type, not the Object.h forward declaration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
9001039and9002265for vehicle6372. Those creatures are never spawned. Merchant Maku's stock is included.6372keeps the howdah seats but uses the mammoth locomotion flags so strafing turns onto the diagonal.Still needed
6372hotfix applies to every user of that vehicle record, not only the player mounts.Test plan