Repository navigation
Conversation
… Style. Steady Flight was flagged not saveable and login always reapplied it, so switching to Skyriding did not stick. Apply 404468 only when neither style aura was loaded, and do not call UpdateMountCapability from the toggle.
Author
|
Gah, the toggle doesn't survive a logout. 404468 is still flagged as not saveable, and login always puts that aura back on, so you end up in steady flight again even if you had switched to 404464. I'll remove that spell fix and only add 404468 when neither aura was loaded: // 404464 Skyriding and 404468 Steady Flight are the saved flight-style auras.
if (!HasAura(404464) && !HasAura(404468))
AddAura(404468, this); |
Shauren
reviewed
Oct 15, 2026
| } | ||
|
|
||
| // Mount capability is chosen from the flight-style aura. | ||
| caster->UpdateMountCapability(); |
Member
There was a problem hiding this comment.
While you can cast this spell in a druid flight form, finishing the cast removes the form on retail making UpdateMountCapability pointless here (and you cannot cast it while mounted)
Oreocide
force-pushed
the
pr/switch-flight-style
branch
3 times, most recently
from
October 15, 2026 14:15
20e9944 to
7c22ab1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpdateMountCapability.2026_10_14_01_world.sql.Still needed
SpellEffect.db2for 404471 and 436854. The handler is effect 0,SPELL_EFFECT_DUMMY. The hotfixesspell_effecttable on this core is empty, and the effect rows were not loaded from DB2 here.Test plan