Repository navigation
Conversation
Read the BattlemasterList type instead of restricting arena classification to five map IDs. Preserve the all-arenas queue special case. Newer arena types should not be allocated client-visible battleground IDs. Test both arena and ordinary battleground metadata through the production client ID allocator. The arena case fails before the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed:
BattlemasterListdata inBattlegroundMgr::IsArenaTypeinstead of the hardcoded arena list.BATTLEGROUND_AAspecial case and return false when the client record is missing.Issues addressed:
Arena types outside the hardcoded list are treated as ordinary battlegrounds when allocating client instance IDs. No linked issue.
Tests performed:
worldserver,bnetserverand tests.BATTLEGROUND_AA.Known issues and TODO list:
Please review the use of
BattlemasterListand the all-arenas special case.