Repository navigation
Conversation
The current client spell 366222 has a summon-pet effect at index 0. The dummy-effect hook never runs, leaving the Incubus selection path unreachable. Register the current effect and prevent the original summon before casting the selected variant. Add a regression through the registered script and real effect dispatcher. It fails on upstream and passes after the fix. Existing world bindings continue to apply.
Contributor
|
close this |
The fixture script is compiled into the test executable. A custom context makes dynamic builds look up a shared script module that does not exist. Register it under the standard static context so script initialization also works with dynamic libraries. Reproduced the dynamic-build assertion locally, verified the correction and passed all 36 CTests in the Debug MySQL build without precompiled headers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed:
SPELL_EFFECT_SUMMON_PET, but the script registersSPELL_EFFECT_DUMMY, so its handler is not called.Issues addressed:
Summon Sayaad does not run its scripted Succubus/Incubus selection. No linked issue.
Tests performed:
worldserver,bnetserverand tests.spell_warl_summon_sayaadbinding. No SQL update is needed.Known issues and TODO list:
Please review the effect hook, default-effect suppression and test fixture.