Core/Spells: Implement S.E.L.F.I.E. camera#31760
Open
Eliminationzx wants to merge 2 commits intoTrinityCore:masterfrom
Open
Core/Spells: Implement S.E.L.F.I.E. camera#31760Eliminationzx wants to merge 2 commits intoTrinityCore:masterfrom
Eliminationzx wants to merge 2 commits intoTrinityCore:masterfrom
Conversation
* Implement background filter quests * Implement selfie camera aura
Shauren
requested changes
Mar 29, 2026
Member
Shauren
left a comment
There was a problem hiding this comment.
- Extra database table is completely unneccessary - unlock can simply be determined by checking if hidden quest is completed
- Text emote is broadcast_text - 141931, 141932, 141933, 141934, 141935
- Send emotes from the script that casts quest completion spells, don't hardcode it in Player::RewardQuest
- Don't set RewardSpell in quest_template (not needed after taking care of points 1 and 3)
- Storing current filter in Player class is also unneccessary, simply use HasAura in cycling spell script
- Use spell_group/spell_group_stack_rules to handle exclusivity (SPELL_GROUP_STACK_RULE_EXCLUSIVE), don't introduce new SpellSpecific
…GROUP_STACK_RULE_EXCLUSIVE), don't introduce new SpellSpecific
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed:
character_background_filtersDB table and prepared statements to persist per-character selfie background filter unlocksspell_item_selfie_camera_mk2), background filter cycling (spell_gen_background_filter), selfie camera filters (spell_gen_selfie_camera_filter), and taking selfies near boss NPCs to complete quests (spell_gen_take_selfie)Issues addressed:
None
Tests performed:
Known issues and TODO list:
spell_gen_selfie_camera_filter::HandleDummy- quest logic not yet implemented for Sketch Filter (181767), Death Filter (181779), and Black and White Filter (181773)spell_gen_take_selfie::SetDest- destination targeting forTARGET_UNIT_CONE_CASTER_TO_DEST_ENTRYnot yet implemented (marked TODO in code)342460 [DNT] Steward Selfie