Core/Pet: Unsummon pet only if the player takes a taxi or is airborne on a flying mount#31744
Open
imstuckbro wants to merge 8 commits intoTrinityCore:3.3.5from
Open
Core/Pet: Unsummon pet only if the player takes a taxi or is airborne on a flying mount#31744imstuckbro wants to merge 8 commits intoTrinityCore:3.3.5from
imstuckbro wants to merge 8 commits intoTrinityCore:3.3.5from
Conversation
Contributor
|
way too many use cases are changed here, we need to split this into more secure changes, and test them separately |
Author
|
It was built to work as a whole, doubt this can be splitted and have positive results. |
Author
|
I think is ready now, in my tests looks decent comparing to retail. |
Contributor
Is this confirmed with sniffs? |
Author
|
haven't really checked, just reused what it already was, looks like in master there's smth like this: TrinityCore/src/server/game/Entities/Unit/Unit.cpp Lines 8306 to 8307 in a738e69 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Issues addressed:
Closes # (insert issue tracker number)
Tests performed:
Does it build, tested in-game, etc.
Known issues and TODO list: (add/remove lines as needed)