Skip to content

Io.js 3.0 support #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TooTallNate merged 13 commits into from
Aug 26, 2015
Merged

Io.js 3.0 support #35

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
eb4b7ca
segafaulting tests escalated
unbornchikken Aug 18, 2015
6d037c6
segfaults when gced
unbornchikken Aug 18, 2015
b8a93f9
restored original object handling code sorry @kkoopa, it wor…
unbornchikken Aug 18, 2015
34ec079
persistent size fixd
unbornchikken Aug 18, 2015
1221a37
int64 conversion works with debug mode iojs runtime
unbornchikken Aug 19, 2015
cbd41ac
new buffers zeroed out to avoid undefined behavior by the specs
unbornchikken Aug 20, 2015
aeb732e
fixed last mistake
unbornchikken Aug 20, 2015
5f3565b
previous mistake fixed, that line was good as is
unbornchikken Aug 21, 2015
270ca83
isolated repro case added
unbornchikken Aug 21, 2015
7c2bd49
fill removed, all OK
unbornchikken Aug 26, 2015
0bdaef1
2.5 + 3 added to appveyor
unbornchikken Aug 26, 2015
a980ebf
updated the io.js 3 test cases to reflect what they are intended to do
unbornchikken Aug 26, 2015
f66ea11
fixed appveyor to test with correct runtime
unbornchikken Aug 26, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updated the io.js 3 test cases to reflect what they are intended to do
  • Loading branch information
@unbornchikken
unbornchikken committed Aug 26, 2015
commit a980ebfafe029e40d41131434a46046eed37a62f
3 changes: 2 additions & 1 deletion test/iojs3issue.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
var assert = require('assert')
var ref = require('../')

// This will check if the new Buffer implementation behaves like the pre io.js 3.0 one did:
describe('iojs3issue', function () {
it('should not crash', function() {
for (var i = 0; i < 10; i++) {
Expand All @@ -11,7 +12,7 @@ describe('iojs3issue', function () {
var buf3 = ref.deref(buf2)
}
})
it('should crash', function() {
it('should not crash too', function() {
for (var i = 0; i < 10; i++) {
gc()
var buf = new Buffer(7)
Expand Down