Skip to content

added a timeout option for connectBlocking#724

Merged
PhilipRoman merged 2 commits into
TooTallNate:masterfrom
cymp:master
Jun 27, 2018
Merged

added a timeout option for connectBlocking#724
PhilipRoman merged 2 commits into
TooTallNate:masterfrom
cymp:master

Conversation

@cymp

@cymp cymp commented Jun 26, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@PhilipRoman PhilipRoman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! I noticed the indentation doesn't match the rest of the code (2 spaces vs 1 tab). Maybe it should be converted for sake of clean diffs when someone decides to autoformat?

@cymp

cymp commented Jun 26, 2018

Copy link
Copy Markdown
Contributor Author

Well I couldn't find a code style settings for this project Which one should I use for IntelliJ?

@PhilipRoman

Copy link
Copy Markdown
Collaborator

CodeFormatterProfile.xml at project root

@cymp

cymp commented Jun 26, 2018

Copy link
Copy Markdown
Contributor Author

Wow sorry...

@cymp

cymp commented Jun 26, 2018

Copy link
Copy Markdown
Contributor Author

I tried to import this eclipse profile in IntelliJ, but it is not perfect (it automatically put the @OverRide annotation left to method declaration for example), so I had to add the tabs myself.

@PhilipRoman

Copy link
Copy Markdown
Collaborator

Tested it, everything works as expected.

@PhilipRoman PhilipRoman merged commit 41b2872 into TooTallNate:master Jun 27, 2018
@cymp

cymp commented Jun 27, 2018

Copy link
Copy Markdown
Contributor Author

@PhilipRoman
Are there any snapshot release, how am I supposed to be able to download via maven what I just did ?

@PhilipRoman

Copy link
Copy Markdown
Collaborator

Not sure what's the best way for this project (I don't use maven for dep management) but as a quick fix, you can always git clone, then mvn package and add the jar as a local library to your project (until next release).

@marci4

marci4 commented Jun 27, 2018

Copy link
Copy Markdown
Collaborator

@PhilipRoman, gratz on your first merged PR! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants