Update WebSocketClient.java#683
Merged
Merged
Conversation
Added check for wss default port to avoid including it into the host. Some servers with proxy balancers may missunderstand the url if it includes the default port.
Collaborator
|
Hello @xcelder, Could you please open an issue for this to discuss the problem, the steps to reproduce and the resulting fix for this ? Thank you! Greetings |
Collaborator
|
Please create an issue or I will close this PR as cannot reproduce! |
Contributor
Author
|
Sorry, i create an issue |
marci4
requested changes
Mar 30, 2018
marci4
left a comment
Collaborator
There was a problem hiding this comment.
Could you please change WbSocket.DEFAULT_WSS_PORT to WebSocket.DEFAULT_WSS_PORT (quess you just had a typo). Thank you!
Typo fixed
marci4
approved these changes
Mar 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added check for wss default port to avoid including it into the host. Some servers with proxy balancers may missunderstand the url if it includes the default port.
Description
Related Issue
Fixes #685
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: