Skip to content

Allow setting custom TCP receive buffer size#1407

Merged
marci4 merged 1 commit into
masterfrom
receive-buffer-size
Apr 27, 2024
Merged

Allow setting custom TCP receive buffer size#1407
marci4 merged 1 commit into
masterfrom
receive-buffer-size

Conversation

@PhilipRoman

@PhilipRoman PhilipRoman commented Apr 14, 2024

Copy link
Copy Markdown
Collaborator

Description

Add new setter/getter which controls the TCP receive buffer size (previously hardcoded as 16K)

Motivation and Context

This is intended to solve #1406 in a more general way

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

TODO

Before merging this I would like to manually verify that setting the buffer size affects performance as expected
Tested, changing the buffer size affects throughput as expected

Also increase default to 64K for performance improvement.
@PhilipRoman PhilipRoman force-pushed the receive-buffer-size branch from dd55832 to f625a1a Compare April 25, 2024 21:53
@PhilipRoman PhilipRoman requested a review from marci4 April 25, 2024 21:53

@marci4 marci4 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@marci4 marci4 added this to the Release 1.5.7 milestone Apr 27, 2024
@marci4 marci4 merged commit 7e47e4d into master Apr 27, 2024
@marci4 marci4 deleted the receive-buffer-size branch April 27, 2024 15:04
@Eric-Alvarez

Copy link
Copy Markdown

@PhilipRoman When is the next release planned? I'm interested in this feature as I've had issues with the current bandwith limitations.

@Vangreen

Vangreen commented Jul 3, 2024

Copy link
Copy Markdown

@PhilipRoman Same here. We also wait for this release. Any update when release is planned?

@PhilipRoman

Copy link
Copy Markdown
Collaborator Author

@marci4

@marci4

marci4 commented Jul 3, 2024

Copy link
Copy Markdown
Collaborator

#1430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants