Skip to content

fix: copyright license script#28

Merged
Panquesito7 merged 3 commits into
mainfrom
fix_copyright_script
Jul 3, 2023
Merged

fix: copyright license script#28
Panquesito7 merged 3 commits into
mainfrom
fix_copyright_script

Conversation

@Panquesito7

@Panquesito7 Panquesito7 commented Jun 27, 2023

Copy link
Copy Markdown
Member

Things added/changed:

  • Fix copyright license script.
    • If there are unpushed changes, the script will attempt to create a PR.
    • When pushing changes, if there are no available commits (which means there were no changes done), the script won't fail anymore.
    • Fix initial_year description that was taken as a string (by using ').
    • When creating a PR, it uses the correct branch and not just master. Every repository has different branch names.

@Panquesito7 Panquesito7 added the bug Something isn't working label Jun 27, 2023
@Panquesito7 Panquesito7 mentioned this pull request Jun 27, 2023
Closed
7 tasks
alexpantyukhin
alexpantyukhin approved these changes Jun 28, 2023
View reviewed changes

@alexpantyukhin alexpantyukhin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks goot to me!

@Panquesito7 Panquesito7 requested a review from tjgurwara99 July 3, 2023 01:36
tjgurwara99
tjgurwara99 reviewed Jul 3, 2023
View reviewed changes
Comment thread license_copyright/license.yml Outdated
Comment thread license_copyright/license.yml Outdated
@Panquesito7 @tjgurwara99
chore: apply suggestions from code review
1587840 
Co-authored-by: Taj <tjgurwara99@users.noreply.github.com>
@Panquesito7 Panquesito7 requested a review from tjgurwara99 July 3, 2023 17:30
@Panquesito7 Panquesito7 merged commit 619ac06 into main Jul 3, 2023
@Panquesito7 Panquesito7 deleted the fix_copyright_script branch July 3, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tjgurwara99 tjgurwara99 tjgurwara99 approved these changes
+1 more reviewer
@alexpantyukhin alexpantyukhin alexpantyukhin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Panquesito7 @alexpantyukhin @tjgurwara99