Moved the formatter script to the formatter action path#14
Merged
Conversation
c8d8007 to
307c420
Compare
Panquesito7
previously approved these changes
Jan 20, 2023
Panquesito7
left a comment
Member
There was a problem hiding this comment.
Cool. Thanks! 🚀
To add backward compatibility, we should keep it. Various repositories still use it from the root directory.
For backward compatibility.
Panquesito7
approved these changes
Jan 20, 2023
Member
|
Forgot to mention: do we need to do this for the directory workflow as well? |
Member
Author
|
Yeah that one also needs to be changed 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix is working - https://github.com/tjgurwara99/scripts/actions/runs/3967396047/jobs/6799328093
I didn't see that you'd moved the
filename_formatter.shout of the action path.