algorithm: AbsoluteValue#31
Merged
raklaptudirm merged 1 commit intoOct 7, 2022
Merged
Conversation
appgurueu
requested changes
Oct 5, 2022
appgurueu
left a comment
Contributor
There was a problem hiding this comment.
The tests & docs are overkill for such a trivial function.
Contributor
Author
|
@appgurueu I tried to include all examples for test cases, so someone completely new to the world of Typescript / Javascript would be able to easily understand what the function does with no prior knowledge. If you like, I can remove some of the tests / documentation, just let me know which ones you would prefer to keep, and which you think should be removed |
Member
|
Even though it is overkill, I guess there is no harm in keeping the tests. |
Contributor
|
I don't think |
raklaptudirm
approved these changes
Oct 7, 2022
raklaptudirm
left a comment
Member
There was a problem hiding this comment.
LGTM. @appgurueu I think there is no harm in keeping the tests. Inform me if you disagree.
appgurueu
approved these changes
Oct 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes changes related to Issue: #10
Included a new maths function to calculate the absolute value of numeric values, as well as associated tests