test: fix square_root.test.ts#229
Merged
raklaptudirm merged 1 commit intoFeb 14, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #229 +/- ##
==========================================
+ Coverage 96.32% 96.71% +0.38%
==========================================
Files 97 97
Lines 1797 1797
Branches 347 347
==========================================
+ Hits 1731 1738 +7
+ Misses 66 59 -7 ☔ View full report in Codecov by Sentry. |
appgurueu
approved these changes
Feb 11, 2024
appgurueu
left a comment
Contributor
There was a problem hiding this comment.
Thanks. Yep, this fixes the tests, hence increasing the coverage. Before, they just created closures that were never called. We should probably introduce a linter to catch mistakes such as this one.
square_root.test.tssquare_root.test.ts
raklaptudirm
approved these changes
Feb 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is something strange with
square_root.test.ts. This PR fixes that.