Feat : Longest Common Subsequence Implementation using Typescript#173
Merged
Conversation
Contributor
Author
|
hi @appgurueu @raklaptudirm , there is some tests falling for quick_select sort algorithm, because of that CI/Tests were falling. My tests were passed in below CI/test 
|
Contributor
We're aware of this. Rak has already PR'd a fix: #174. |
appgurueu
reviewed
Oct 4, 2023
| const lcs: string[] = []; | ||
| while (i > 0 && j > 0) { | ||
| if (text1[i - 1] === text2[j - 1]) { | ||
| lcs.unshift(text1[i - 1]); |
Contributor
There was a problem hiding this comment.
Side note: This is needlessly inefficient (unshifting is linear time, making the reconstruction O(min(n,m)²) where n, m are the lengths of the two strings; it would be more efficient to just push and reverse later before joining), but I don't think it affects the asymptotic time complexity, which should still be O(nm).
appgurueu
approved these changes
Oct 4, 2023
raklaptudirm
approved these changes
Oct 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added feature of LCS implementation using tabluation approach in typescript