Skip to content

Add pep8-naming to pre-commit hooks and fixes incorrect naming conventions - #7062

Merged
cclauss merged 8 commits into
TheAlgorithms:masterfrom
CaedenPH:origin/pep8-naming
Oct 12, 2022
Merged

Add pep8-naming to pre-commit hooks and fixes incorrect naming conventions#7062
cclauss merged 8 commits into
TheAlgorithms:masterfrom
CaedenPH:origin/pep8-naming

Conversation

@CaedenPH

@CaedenPH CaedenPH commented Oct 12, 2022

Copy link
Copy Markdown
Contributor

Describe your change:

Fixes naming conventions and adds pep-8 naming to pre-commit hooks
#7038

This code does not edit any variable names other than changing from mixedCase to snake_case.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper Bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 12, 2022
@CaedenPH

CaedenPH commented Oct 12, 2022

Copy link
Copy Markdown
Contributor Author

Will work on failing checks tommorow

@cclauss

cclauss commented Oct 12, 2022

Copy link
Copy Markdown
Member

WOW!!!

You win the gold star if you can land this one!! I had no idea it would 130+ files!!

cclauss
cclauss reviewed Oct 12, 2022
View reviewed changes
Comment thread arithmetic_analysis/lu_decomposition.py Outdated
@CaedenPH

CaedenPH commented Oct 12, 2022

Copy link
Copy Markdown
Contributor Author

Please note that project euler problem 104 is failing, however I did not change this file.

@CaedenPH

CaedenPH commented Oct 12, 2022

Copy link
Copy Markdown
Contributor Author

Please note that project euler problem 104 is failing, however I did not change this file.

@cclauss what should I do about this?

@cclauss

cclauss commented Oct 12, 2022

Copy link
Copy Markdown
Member

Try to rename sol.py to sol.py.FIXME and hope that disables that test.
If it does then please open a new issue to fix 104 after this PR lands.

@algorithms-keeper algorithms-keeper Bot removed the tests are failing Do not merge until tests pass label Oct 12, 2022
@CaedenPH

CaedenPH commented Oct 12, 2022

Copy link
Copy Markdown
Contributor Author

@cclauss
All tests are successful!

cclauss
cclauss approved these changes Oct 12, 2022
View reviewed changes

@cclauss cclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ 🌟 ⭐
🚀 🥳 🎁

@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Oct 12, 2022
@cclauss
cclauss merged commit 07e991d into TheAlgorithms:master Oct 12, 2022
@cclauss

cclauss commented Oct 12, 2022

Copy link
Copy Markdown
Member

If you are up for a smaller, easier one then please add flake8-builtins to pre-commit.

@CaedenPH

CaedenPH commented Oct 13, 2022

Copy link
Copy Markdown
Contributor Author

If you are up for a smaller, easier one then please add flake8-builtins to pre-commit.

Good morning, I will work on this when I have time

@CaedenPH
CaedenPH deleted the origin/pep8-naming branch October 13, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes
@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila
@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees

No one assigned

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CaedenPH @cclauss