Skip to content

Financials #5585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cclauss merged 18 commits into from
Oct 26, 2021
Merged

Financials #5585

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
ed89816
feat: creates math calculations for financials
tarcisiobruni Oct 24, 2021
ff0cde7
refactor: make pull request items requirements
tarcisiobruni Oct 24, 2021
e00a875
refactor: provides type hint for parameters
tarcisiobruni Oct 24, 2021
1e5cc30
refactor: applies code review suggestions
tarcisiobruni Oct 24, 2021
522dcbf
refactor: adds more examples tests
tarcisiobruni Oct 24, 2021
5234d8d
refactor: throws ValueError instead of Exception
tarcisiobruni Oct 24, 2021
980f40d
refactor: fix formatting
tarcisiobruni Oct 24, 2021
3de2457
refactor: fix formatting
tarcisiobruni Oct 24, 2021
110da41
Update interest.py
cclauss Oct 26, 2021
c3dd88b
Update and rename financials/ABOUT.md to financial/ABOUT.md
cclauss Oct 26, 2021
c1fb8d0
Rename financials/__init__.py to financial/__init__.py
cclauss Oct 26, 2021
4807cac
Rename financials/interest.py to financial/interest.py
cclauss Oct 26, 2021
bc6304e
https://www.investopedia.com
cclauss Oct 26, 2021
d953fa3
Update __init__.py
cclauss Oct 26, 2021
f6e7408
pre-commit: Disable end-of-file-fixer
cclauss Oct 26, 2021
d551e4e
Revert change to pre-commit
cclauss Oct 26, 2021
787a9b5
Update __init__.py
poyea Oct 26, 2021
34a2b72
__init__.py
poyea Oct 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: fix formatting
  • Loading branch information
@tarcisiobruni
tarcisiobruni committed Oct 24, 2021
commit 980f40df3f7bdd7da4e804d77dc43a870500dc5f
23 changes: 15 additions & 8 deletions financials/interest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
from __future__ import annotations

def simple_interest(principle:float, daily_interest_rate:float, number_of_days_between_payments:int) -> float:

def simple_interest(
principle: float, daily_interest_rate: float, number_of_days_between_payments: int
) -> float:
"""
>>> simple_interest(18000.0,0.06,3)
3240.0
Copy link
Copy Markdown
Member

@cclauss cclauss Oct 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests dealing with zero principle, negative principle, zero interest rate, negative interest rate, zero days, negative days, etc.

Copy link
Copy Markdown
Contributor Author

@tarcisiobruni tarcisiobruni Oct 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cclauss done

Expand All @@ -25,17 +28,21 @@ def simple_interest(principle:float, daily_interest_rate:float, number_of_days_b
...
ValueError: number_of_days_between_payments must be >= 0
"""
if(number_of_days_between_payments < 0):
if number_of_days_between_payments < 0:
raise ValueError("number_of_days_between_payments must be >= 0")
if(daily_interest_rate < 0.0):
if daily_interest_rate < 0.0:
raise ValueError("daily_interest_rate must be >= 0")
if(principle < 0.0):
if principle < 0.0:
raise ValueError("principle must be >= 0")

return principle * daily_interest_rate * number_of_days_between_payments


def compound_interest(principle:float, nominal_annual_interest_rate_percentage:float, number_of_compounding_periods:int)-> float:
def compound_interest(
principle: float,
nominal_annual_interest_rate_percentage: float,
number_of_compounding_periods: int,
) -> float:
"""
>>> compound_interest(10000.0,0.05,3)
1576.2500000000014
Expand All @@ -58,11 +65,11 @@ def compound_interest(principle:float, nominal_annual_interest_rate_percentage:f
...
ValueError: principle must be >= 0
"""
if(number_of_compounding_periods < 0):
if number_of_compounding_periods < 0:
raise ValueError("number_of_compounding_periods must be >= 0")
if(nominal_annual_interest_rate_percentage < 0.0):
if nominal_annual_interest_rate_percentage < 0.0:
raise ValueError("nominal_annual_interest_rate_percentage must be >= 0")
if(principle < 0.0):
if principle < 0.0:
raise ValueError("principle must be >= 0")

return principle * ((1 + nominal_annual_interest_rate_percentage) ** number_of_compounding_periods - 1)
Expand Down