Skip to content

Add gabor filter#5289

Merged
poyea merged 8 commits intoTheAlgorithms:masterfrom
Mozartuss:master
Nov 2, 2021
Merged

Add gabor filter#5289
poyea merged 8 commits intoTheAlgorithms:masterfrom
Mozartuss:master

Conversation

@Mozartuss
Copy link
Copy Markdown
Contributor

@Mozartuss Mozartuss commented Oct 14, 2021 •
edited
Loading

Describe your change:

Add the Gabor filter, which can extract and analyze image textures.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Oct 14, 2021
ghost
ghost reviewed Oct 14, 2021
View reviewed changes
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment thread digital_image_processing/filters/gabor_filter.py Outdated
ghost
ghost reviewed Oct 14, 2021
View reviewed changes
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment thread digital_image_processing/filters/gabor_filter.py Outdated
@Mozartuss Mozartuss marked this pull request as draft October 14, 2021 12:48
@Mozartuss Mozartuss marked this pull request as ready for review October 14, 2021 13:12
@ghost ghost added tests are failing Do not merge until tests pass and removed require type hints https://docs.python.org/3/library/typing.html labels Oct 14, 2021
ghost
ghost reviewed Oct 14, 2021
View reviewed changes
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment thread digital_image_processing/filters/gabor_filter.py
@ghost ghost removed the require tests Tests [doctest/unittest/pytest] are required label Oct 15, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Oct 15, 2021
poyea
poyea reviewed Oct 19, 2021
View reviewed changes
Comment thread digital_image_processing/filters/gabor_filter.py
@poyea poyea self-assigned this Oct 19, 2021
@Mozartuss @poyea
Update digital_image_processing/filters/gabor_filter.py
08d703e 
Co-authored-by: John Law <johnlaw.po@gmail.com>
@Mozartuss Mozartuss requested a review from poyea October 21, 2021 07:19
@poyea
Copy link
Copy Markdown
Member

poyea commented Oct 27, 2021

It seems to have slightly different output than https://docs.opencv.org/4.5.4/d4/d86/group__imgproc__filter.html#gae84c92d248183bd92fa713ce51cc3599

poyea
poyea reviewed Oct 27, 2021
View reviewed changes
Comment thread digital_image_processing/filters/gabor_filter.py Outdated
@poyea poyea added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 27, 2021
@Mozartuss
Copy link
Copy Markdown
Contributor Author

Mozartuss commented Nov 1, 2021

It seems to have slightly different output than https://docs.opencv.org/4.5.4/d4/d86/group__imgproc__filter.html#gae84c92d248183bd92fa713ce51cc3599

I accidentally took theta as angle measure instead of radian, now my function return the same as the openCV function.

@Mozartuss Mozartuss requested a review from poyea November 1, 2021 22:43
poyea
poyea approved these changes Nov 2, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Nov 2, 2021
@poyea poyea merged commit 424c200 into TheAlgorithms:master Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poyea poyea poyea approved these changes

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

@poyea poyea

Labels

hacktoberfest-accepted Accepted to be counted towards Hacktoberfest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Mozartuss @poyea