Skip to content

Added algorithm for creating Hamming numbers series in Python - #4992

Merged
poyea merged 7 commits into
TheAlgorithms:masterfrom
und1n3:hamming_branch
Jul 16, 2022
Merged

Added algorithm for creating Hamming numbers series in Python#4992
poyea merged 7 commits into
TheAlgorithms:masterfrom
und1n3:hamming_branch

Conversation

@und1n3

@und1n3 und1n3 commented Oct 4, 2021

Copy link
Copy Markdown
Contributor

Describe your change:

Added algorim in python/math/series to create the hamming numbers series up to the nth number requested.

  • [x ] Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@und1n3
und1n3 requested a review from Kush1101 as a code owner October 4, 2021 13:15
@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Oct 4, 2021

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment thread maths/series/hamming_numbers.py Outdated
@und1n3

und1n3 commented Oct 4, 2021

Copy link
Copy Markdown
Contributor Author

Is this PR eligible to the Hacktoberfest? Thanks!

Comment thread maths/series/hamming_numbers.py Outdated
Comment thread maths/series/hamming_numbers.py Outdated
Comment thread maths/series/hamming_numbers.py Outdated
@poyea

poyea commented Oct 26, 2021

Copy link
Copy Markdown
Member

Let's call this file hamming?

@ghost ghost added the tests are failing Do not merge until tests pass label Oct 26, 2021
@poyea poyea self-assigned this Dec 16, 2021
@stale

stale Bot commented Apr 19, 2022

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale Used to mark an issue or pull request stale. label Apr 19, 2022
@stale stale Bot removed the stale Used to mark an issue or pull request stale. label Jul 16, 2022
@ghost ghost removed the tests are failing Do not merge until tests pass label Jul 16, 2022
@poyea poyea added the awaiting merge This PR is approved and ready to be merged label Jul 16, 2022

@poyea poyea left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@ghost ghost removed awaiting reviews This PR is ready to be reviewed awaiting merge This PR is approved and ready to be merged labels Jul 16, 2022
@poyea
poyea merged commit b3d9281 into TheAlgorithms:master Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants