Skip to content

Updated name from lstm_prediction.py_tf to lstm_prediction.py and also imported keras#4422

Merged
cclauss merged 6 commits into
TheAlgorithms:masterfrom
Jenil-S:my-small-contribution
May 17, 2021
Merged

Updated name from lstm_prediction.py_tf to lstm_prediction.py and also imported keras#4422
cclauss merged 6 commits into
TheAlgorithms:masterfrom
Jenil-S:my-small-contribution

Conversation

@Jenil-S
Copy link
Copy Markdown
Contributor

@Jenil-S Jenil-S commented May 16, 2021

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels May 16, 2021
@Jenil-S Jenil-S changed the title Updated name from lstm_prediction.py_lf to lstm_prediction.py and also imported keras Updated name from lstm_prediction.py_tf to lstm_prediction.py and also imported keras May 16, 2021
onlinejudge95
onlinejudge95 requested changes May 16, 2021
View reviewed changes
Comment thread machine_learning/lstm/lstm_prediction.py Outdated
@ghost ghost added the tests are failing Do not merge until tests pass label May 17, 2021
@Jenil-S
Copy link
Copy Markdown
Contributor Author

Jenil-S commented May 17, 2021

@onlinejudge95 Why it is failing??

@onlinejudge95
Copy link
Copy Markdown
Collaborator

onlinejudge95 commented May 17, 2021 •
edited
Loading

@onlinejudge95 Why it is failing??

Did you try checking the GitHub action logs?
The reason it is failing is that in the Install dependencies section it is skipping installation of keras and tensorflow

...
Ignoring keras: markers 'python_version < "3.9"' don't match your environment
Ignoring tensorflow: markers 'python_version < "3.9"' don't match your environment
...

Now if we see the version of python that we are using in the runner is 3.9 hence these 2 dependencies will never be installed.

@cclauss any blockers we have on un pinning the python versions for these 2 libraries?

@Jenil-S
Copy link
Copy Markdown
Contributor Author

Jenil-S commented May 17, 2021

@onlinejudge95 Why it is failing??

Did you try checking the GitHub action logs?
The reason it is failing is that in the Install dependencies section it is skipping installation of keras and tensorflow

...
Ignoring keras: markers 'python_version < "3.9"' don't match your environment
Ignoring tensorflow: markers 'python_version < "3.9"' don't match your environment
...

Now if we see the version of python that we are using in the runner is 3.9 hence these 2 dependencies will never be installed.

@cclauss any blockers we have on un pinning the python versions for these 2 libraries?

No I haven't seen now what should I do??

@onlinejudge95 onlinejudge95 mentioned this pull request May 17, 2021
Closed
@onlinejudge95
Copy link
Copy Markdown
Collaborator

onlinejudge95 commented May 17, 2021

There is already a PR to sort this issue. Once it will be merged your build will be passing.

@Jenil-S
Copy link
Copy Markdown
Contributor Author

Jenil-S commented May 17, 2021

There is already a PR to sort this issue. Once it will be merged your build will be passing.

okay thanks!!

@cclauss
Copy link
Copy Markdown
Member

cclauss commented May 17, 2021

Closing and reopening to sync with master.

@cclauss cclauss closed this May 17, 2021
@cclauss cclauss reopened this May 17, 2021
@cclauss
Copy link
Copy Markdown
Member

cclauss commented May 17, 2021

Still needs a fix for #4370

@ghost ghost removed the tests are failing Do not merge until tests pass label May 17, 2021
@cclauss cclauss merged commit 7d7c797 into TheAlgorithms:master May 17, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label May 17, 2021
@cclauss
Copy link
Copy Markdown
Member

cclauss commented May 17, 2021

Well done! Thx.

This was referenced May 17, 2021
Closed
Closed
Closed
@Jenil-S Jenil-S deleted the my-small-contribution branch May 18, 2021 11:54
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@Jenil-S @cclauss @shermanhui
Updated name from lstm_prediction.py_tf to lstm_prediction.py and als…
f85b05b 
…o imported keras (TheAlgorithms#4422)

* Updated name from lstm_prediction.py_lf to lstm_prediction.py and also imported keras

* Edited the changes

* tensorflow 2.5 is has shipped!!!

* Update lstm_prediction.py

* Update lstm_prediction.py

* One blank line, not two?

Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@onlinejudge95 onlinejudge95 onlinejudge95 approved these changes

Assignees

No one assigned

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jenil-S @onlinejudge95 @cclauss