Skip to content

Balanced parentheses#3768

Merged
cclauss merged 8 commits into
TheAlgorithms:masterfrom
realDuYuanChao:balanced_parentheses
Oct 29, 2020
Merged

Balanced parentheses#3768
cclauss merged 8 commits into
TheAlgorithms:masterfrom
realDuYuanChao:balanced_parentheses

Conversation

@realDuYuanChao
Copy link
Copy Markdown
Member

@realDuYuanChao realDuYuanChao commented Oct 27, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

cclauss
cclauss reviewed Oct 27, 2020
View reviewed changes
Comment thread data_structures/stacks/balanced_parentheses.py Outdated
cclauss
cclauss reviewed Oct 27, 2020
View reviewed changes
Comment thread data_structures/stacks/balanced_parentheses.py Outdated

def is_paired(left_bracket: str, right_bracket: str) -> bool:
"""
>>> brackets = {"(" : ")", "[" : "]", "{" : "}"}
Copy link
Copy Markdown
Member

@cclauss cclauss Oct 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s make this dict a global named bracket_pairs and then we can eliminate is_paired() because it is the same as bracket_pairs[left_bracket] == right_bracket

@realDuYuanChao
Copy link
Copy Markdown
Member Author

realDuYuanChao commented Oct 29, 2020 •
edited
Loading

@cclauss @poyea @dhruvmanila Can you review this PR 👍

cclauss
cclauss reviewed Oct 29, 2020
View reviewed changes
Comment thread data_structures/stacks/balanced_parentheses.py Outdated
@realDuYuanChao @cclauss
Update data_structures/stacks/balanced_parentheses.py
030a8f7 
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
cclauss reviewed Oct 29, 2020
View reviewed changes
Comment thread data_structures/stacks/balanced_parentheses.py Outdated
cclauss
cclauss reviewed Oct 29, 2020
View reviewed changes
Comment thread data_structures/stacks/balanced_parentheses.py
>>> balanced_parentheses("[()]{}{[()()]()}")
True
>>> balanced_parentheses("[(])")
False
Copy link
Copy Markdown
Member

@cclauss cclauss Oct 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a string that has no brackets and also an empty string.

Copy link
Copy Markdown
Member Author

@realDuYuanChao realDuYuanChao Oct 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Please review again.

realDuYuanChao and others added 2 commits October 29, 2020 17:00
@cclauss cclauss merged commit a03b3f7 into TheAlgorithms:master Oct 29, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@realDuYuanChao @cclauss @stokhos
Balanced parentheses (TheAlgorithms#3768)
2efd738 
* Fixed balanced_parentheses.py

* fixed pre-commit

* eliminate is_paired

* remove unused line

* updating DIRECTORY.md

* Update data_structures/stacks/balanced_parentheses.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Add more test cases

* Update data_structures/stacks/balanced_parentheses.py

Co-authored-by: Christian Clauss <cclauss@me.com>

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@realDuYuanChao @cclauss @peRFectBeliever
Balanced parentheses (TheAlgorithms#3768)
9588df7 
* Fixed balanced_parentheses.py

* fixed pre-commit

* eliminate is_paired

* remove unused line

* updating DIRECTORY.md

* Update data_structures/stacks/balanced_parentheses.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Add more test cases

* Update data_structures/stacks/balanced_parentheses.py

Co-authored-by: Christian Clauss <cclauss@me.com>

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@realDuYuanChao @cclauss
Balanced parentheses (TheAlgorithms#3768)
e6226cf 
* Fixed balanced_parentheses.py

* fixed pre-commit

* eliminate is_paired

* remove unused line

* updating DIRECTORY.md

* Update data_structures/stacks/balanced_parentheses.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Add more test cases

* Update data_structures/stacks/balanced_parentheses.py

Co-authored-by: Christian Clauss <cclauss@me.com>

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@realDuYuanChao @cclauss @shermanhui
Balanced parentheses (TheAlgorithms#3768)
a39d527 
* Fixed balanced_parentheses.py

* fixed pre-commit

* eliminate is_paired

* remove unused line

* updating DIRECTORY.md

* Update data_structures/stacks/balanced_parentheses.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Add more test cases

* Update data_structures/stacks/balanced_parentheses.py

Co-authored-by: Christian Clauss <cclauss@me.com>

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

@poyea poyea Awaiting requested review from poyea

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

@l3str4nge l3str4nge Awaiting requested review from l3str4nge

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@realDuYuanChao @cclauss