Create euclidean_distance.py by andrewctam · Pull Request #3350 · TheAlgorithms/Python

andrewctam · 2020-10-15T21:06:10Z

Describe your change:

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

TravisBuddy · 2020-10-15T21:12:34Z

Travis tests have failed

Hey @ac-tam,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 22646fb0-0f2b-11eb-9bff-abeacd856cb9

andrewctam

Updated name and generalized

TravisBuddy · 2020-10-16T15:16:31Z

Travis tests have failed

Hey @ac-tam,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 8f4e0860-0fc2-11eb-8acb-27a1e4e1eb88

TravisBuddy · 2020-10-16T15:16:31Z

Travis tests have failed

Hey @ac-tam,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 8f494d70-0fc2-11eb-8acb-27a1e4e1eb88

TravisBuddy · 2020-10-16T15:16:31Z

Travis tests have failed

Hey @ac-tam,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 8f535f90-0fc2-11eb-8acb-27a1e4e1eb88

cozek · 2020-10-17T05:35:42Z

Hi @ac-tam . You have made good progress. Just read the Travis error logs and make your code comply with the contribution guidelines.

andrewctam

Added suggestions

cclauss · 2020-10-19T05:51:43Z

This is looking cool! Please add or delete the doctest for 2.8284271247461903 as suggested by @cozek. Let’s try to benchmark a numpy version of this algorithm against a non-numpy version. Please rename the current function to euclidean_distance_np() and create a new euclidean_distance() function that has the same function signature but does not use numpy. Then we can add a timeit benchmark to see the performance difference.

dhruvmanila · 2020-11-27T04:53:16Z

+
+
+if __name__ == "__main__":
+  def benchmark() -> None:


I am sorry if I was not clear but I meant to remove the function and just keep the code.

Co-authored-by: Christian Clauss <cclauss@me.com>

cclauss

Nice work! Cool to see the benchmark.

* Create distance_formula.py * Remove whitespace * Update distance_formula.py * Update distance_formula.py * Update distance_formula.py * Generalize * Grammar mistake * Rename distance_formula.py to euclidean_distance.py * Update euclidean_distance.py * v1 - > v2 * Update euclidean_distance.py * Update euclidean_distance.py * Update euclidean_distance.py * Update euclidean_distance.py * Update euclidean_distance.py * Update euclidean_distance.py * Update maths/euclidean_distance.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update euclidean_distance.py * Update euclidean_distance.py * Update euclidean_distance.py * Update euclidean_distance.py * Update euclidean_distance.py * Update euclidean_distance.py * Update euclidean_distance.py * Update euclidean_distance.py * Update euclidean_distance.py * Update euclidean_distance.py * Update euclidean_distance.py * Update euclidean_distance.py * Update euclidean_distance.py * Update euclidean_distance.py * Update euclidean_distance.py * Update euclidean_distance.py * Update euclidean_distance.py * Update euclidean_distance.py * Update euclidean_distance.py * Update maths/euclidean_distance.py Co-authored-by: Christian Clauss <cclauss@me.com> Co-authored-by: Christian Clauss <cclauss@me.com>

Create distance_formula.py

91b6ee6

andrewctam requested a review from Kush1101 as a code owner October 15, 2020 21:06

andrewctam added 4 commits October 15, 2020 17:18

Remove whitespace

eb044a3

Update distance_formula.py

861ce33

Update distance_formula.py

9102f3e

Update distance_formula.py

2cd354b

cozek suggested changes Oct 16, 2020

View reviewed changes

Comment thread maths/distance_formula.py Outdated

Comment thread maths/distance_formula.py Outdated

andrewctam added 2 commits October 16, 2020 09:54

Generalize

36f90ae

Grammar mistake

9186ba9

andrewctam commented Oct 16, 2020

View reviewed changes

Rename distance_formula.py to euclidean_distance.py

4dd283a

andrewctam changed the title ~~Create distance_formula.py~~ Create euclidean_distance.py Oct 16, 2020

andrewctam added 2 commits October 16, 2020 10:10

Update euclidean_distance.py

01a1ea9

v1 - > v2

0451a5b

Update euclidean_distance.py

3940049

cozek suggested changes Oct 17, 2020

View reviewed changes

Comment thread maths/euclidean_distance.py Outdated

Comment thread maths/euclidean_distance.py Outdated

Comment thread maths/euclidean_distance.py Outdated

andrewctam added 5 commits October 18, 2020 21:41

Update euclidean_distance.py

de64392

Update euclidean_distance.py

5a092eb

Update euclidean_distance.py

b5152b2

Update euclidean_distance.py

a1b9a86

Update euclidean_distance.py

ac0ff37

andrewctam commented Oct 19, 2020

View reviewed changes

cozek reviewed Oct 19, 2020

View reviewed changes

Comment thread maths/euclidean_distance.py

cclauss reviewed Oct 19, 2020

View reviewed changes

Comment thread maths/euclidean_distance.py Outdated

ghost added the awaiting reviews This PR is ready to be reviewed label Nov 27, 2020

cclauss reviewed Nov 27, 2020

View reviewed changes

Comment thread maths/euclidean_distance.py Outdated

Update euclidean_distance.py

aad0d3a

ghost added require tests Tests [doctest/unittest/pytest] are required and removed awaiting reviews This PR is ready to be reviewed labels Nov 27, 2020

dhruvmanila reviewed Nov 27, 2020

View reviewed changes

Comment thread maths/euclidean_distance.py Outdated

Update euclidean_distance.py

4a08254

ghost added the tests are failing Do not merge until tests pass label Nov 27, 2020

andrewctam added 2 commits November 26, 2020 23:45

Update euclidean_distance.py

017eb73

Update euclidean_distance.py

f16b2bb

ghost added awaiting reviews This PR is ready to be reviewed and removed require tests Tests [doctest/unittest/pytest] are required tests are failing Do not merge until tests pass labels Nov 27, 2020

dhruvmanila reviewed Nov 27, 2020

View reviewed changes

ghost added tests are failing Do not merge until tests pass and removed awaiting reviews This PR is ready to be reviewed labels Nov 27, 2020

Update euclidean_distance.py

8e83ae6

ghost added awaiting reviews This PR is ready to be reviewed and removed tests are failing Do not merge until tests pass labels Nov 27, 2020

andrewctam requested a review from cclauss November 27, 2020 05:00

cclauss reviewed Nov 27, 2020

View reviewed changes

Comment thread maths/euclidean_distance.py Outdated

Update maths/euclidean_distance.py

ccdd50e

Co-authored-by: Christian Clauss <cclauss@me.com>

andrewctam requested a review from cclauss November 27, 2020 14:39

cclauss approved these changes Nov 27, 2020

View reviewed changes

ghost removed the awaiting reviews This PR is ready to be reviewed label Nov 27, 2020

cclauss merged commit 10427f8 into TheAlgorithms:master Nov 27, 2020

Uh oh!

Uh oh!

Conversation

andrewctam commented Oct 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your change:

Checklist:

Uh oh!

TravisBuddy commented Oct 15, 2020

Travis tests have failed

TravisBuddy Request Identifier: 22646fb0-0f2b-11eb-9bff-abeacd856cb9

Uh oh!

Uh oh!

Uh oh!

andrewctam left a comment

Choose a reason for hiding this comment

Uh oh!

TravisBuddy commented Oct 16, 2020

Travis tests have failed

TravisBuddy Request Identifier: 8f4e0860-0fc2-11eb-8acb-27a1e4e1eb88

Uh oh!

TravisBuddy commented Oct 16, 2020

Travis tests have failed

TravisBuddy Request Identifier: 8f494d70-0fc2-11eb-8acb-27a1e4e1eb88

Uh oh!

TravisBuddy commented Oct 16, 2020

Travis tests have failed

TravisBuddy Request Identifier: 8f535f90-0fc2-11eb-8acb-27a1e4e1eb88

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cozek commented Oct 17, 2020

Uh oh!

andrewctam left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cclauss commented Oct 19, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dhruvmanila Nov 27, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cclauss left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

andrewctam commented Oct 15, 2020 •

edited

Loading