Create vector3_for_2d_rendering.py · Pull Request #2496 · TheAlgorithms/Python

ghost · 2020-09-27T04:34:20Z

Edited for passing travis test

Describe your change:

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

Edited for passing travis test

TravisBuddy · 2020-09-27T04:37:58Z

Hey @xcodz-dot,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 36d37fe0-007b-11eb-a257-6fde496095bb

ghost · 2020-09-27T05:04:57Z

Hey @xcodz-dot,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 36d37fe0-007b-11eb-a257-6fde496095bb

now i am done

ghost · 2020-09-27T05:34:53Z

please review my pull request

Compressed the line 19 to 28 into 19 to 21

TravisBuddy · 2020-09-28T05:31:14Z

Hey @xcodz-dot,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: d1eeb870-014b-11eb-9be6-0d9634a5fbe7

TravisBuddy · 2020-09-28T06:19:51Z

Hey @xcodz-dot,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 9c7a9f40-0152-11eb-9be6-0d9634a5fbe7

TravisBuddy · 2020-09-28T06:21:44Z

Hey @xcodz-dot,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: e07a4e70-0152-11eb-9be6-0d9634a5fbe7

cclauss · 2020-09-28T06:23:53Z

https://travis-ci.com/github/TheAlgorithms/Python/jobs/391659513#L252-L263

completly corrected pep8 errors using Pycharm IDE

ghost · 2020-09-28T06:26:37Z

Edited code to get approved

TravisBuddy · 2020-09-28T06:29:31Z

Hey @xcodz-dot,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: f6b7dc10-0153-11eb-9be6-0d9634a5fbe7

ghost · 2020-09-28T06:33:11Z

editing

ghost · 2020-09-28T06:41:40Z

please review it

Co-authored-by: Dhruv <dhruvmanila@gmail.com>

TravisBuddy · 2020-09-28T06:45:58Z

Hey @xcodz-dot,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 42fdb2f0-0156-11eb-9be6-0d9634a5fbe7

TravisBuddy · 2020-09-28T06:48:29Z

Hey @xcodz-dot,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 9d27f970-0156-11eb-9be6-0d9634a5fbe7

TravisBuddy · 2020-09-28T06:49:52Z

Hey @xcodz-dot,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: ce7ce940-0156-11eb-9be6-0d9634a5fbe7

ghost · 2020-09-28T06:56:15Z

done and approved by travis

cclauss

Thanks for your perseverance we will get this one merged soon.

Co-authored-by: Christian Clauss <cclauss@me.com>

TravisBuddy · 2020-09-28T07:51:24Z

Hey @xcodz-dot,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 66f0a560-015f-11eb-9be6-0d9634a5fbe7

Added A few extra names to __author__ 😄

Used Pycharm to fix PEP8 errors, doctest errors

TravisBuddy · 2020-09-28T07:55:54Z

Hey @xcodz-dot,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 07eef0c0-0160-11eb-9be6-0d9634a5fbe7

Added enough doctests

ghost · 2020-09-28T08:19:28Z

It is very hard work to comply with all the requirements 😫. But still i am happy for contributions 😄

ghost · 2020-09-28T08:20:34Z

please review

ghost

done tests, added doctests, requested changes done

Co-authored-by: Christian Clauss <cclauss@me.com>

TravisBuddy · 2020-09-28T09:27:52Z

Hey @xcodz-dot,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: e08d1450-016c-11eb-9be6-0d9634a5fbe7

cclauss

Nice work! Thanks for doing this.

* Create vector3_for_2d_rendering.py Edited for passing travis test * Delete vector3_for_2d_rendering.py * Create vector3_for_2d_rendering.py * Update vector3_for_2d_rendering.py Compressed the line 19 to 28 into 19 to 21 * Update vector3_for_2d_rendering.py * Update vector3_for_2d_rendering.py * Update vector3_for_2d_rendering.py completly corrected pep8 errors using Pycharm IDE * Update vector3_for_2d_rendering.py * Update graphics/vector3_for_2d_rendering.py Co-authored-by: Dhruv <dhruvmanila@gmail.com> * Update graphics/vector3_for_2d_rendering.py Co-authored-by: Dhruv <dhruvmanila@gmail.com> * Update graphics/vector3_for_2d_rendering.py Co-authored-by: Dhruv <dhruvmanila@gmail.com> * Update vector3_for_2d_rendering.py * Update vector3_for_2d_rendering.py * Update graphics/vector3_for_2d_rendering.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update graphics/vector3_for_2d_rendering.py Co-authored-by: Christian Clauss <cclauss@me.com> * Apply suggestions from code review Co-authored-by: Christian Clauss <cclauss@me.com> * Update vector3_for_2d_rendering.py Added A few extra names to __author__ 😄 * Update vector3_for_2d_rendering.py Used Pycharm to fix PEP8 errors, doctest errors * Update vector3_for_2d_rendering.py Added enough doctests * Update graphics/vector3_for_2d_rendering.py Co-authored-by: Christian Clauss <cclauss@me.com> * Remove second main() Co-authored-by: Dhruv <dhruvmanila@gmail.com> Co-authored-by: Christian Clauss <cclauss@me.com>

Create vector3_for_2d_rendering.py

9590d36

Edited for passing travis test

xcodz-dot added 2 commits September 27, 2020 10:13

Delete vector3_for_2d_rendering.py

57ee51c

Create vector3_for_2d_rendering.py

2775efe

ghost commented Sep 27, 2020

View reviewed changes

Comment thread graphics/vector3_for_2d_rendering.py Outdated

ghost commented Sep 27, 2020

View reviewed changes

Comment thread graphics/vector3_for_2d_rendering.py Outdated

ghost commented Sep 27, 2020

View reviewed changes

Comment thread graphics/vector3_for_2d_rendering.py Outdated

ghost commented Sep 27, 2020

View reviewed changes

Comment thread graphics/vector3_for_2d_rendering.py Outdated

ghost commented Sep 27, 2020

View reviewed changes

Comment thread graphics/vector3_for_2d_rendering.py

dhruvmanila reviewed Sep 28, 2020

View reviewed changes

Comment thread graphics/vector3_for_2d_rendering.py Outdated

Update vector3_for_2d_rendering.py

d9fcc66

Compressed the line 19 to 28 into 19 to 21

dhruvmanila reviewed Sep 28, 2020

View reviewed changes

Comment thread graphics/vector3_for_2d_rendering.py Outdated

xcodz-dot added 2 commits September 28, 2020 11:46

Update vector3_for_2d_rendering.py

ae70f41

Update vector3_for_2d_rendering.py

3e52831

Update vector3_for_2d_rendering.py

ccb6c9f

completly corrected pep8 errors using Pycharm IDE

Update vector3_for_2d_rendering.py

828f11a

dhruvmanila reviewed Sep 28, 2020

View reviewed changes

Comment thread graphics/vector3_for_2d_rendering.py Outdated

Update graphics/vector3_for_2d_rendering.py

9975733

Co-authored-by: Dhruv <dhruvmanila@gmail.com>

dhruvmanila reviewed Sep 28, 2020

View reviewed changes

Comment thread graphics/vector3_for_2d_rendering.py Outdated

Update graphics/vector3_for_2d_rendering.py

022f7d5

Co-authored-by: Dhruv <dhruvmanila@gmail.com>

dhruvmanila reviewed Sep 28, 2020

View reviewed changes

Comment thread graphics/vector3_for_2d_rendering.py Outdated

Update graphics/vector3_for_2d_rendering.py

7b13ddc

Co-authored-by: Dhruv <dhruvmanila@gmail.com>

Update vector3_for_2d_rendering.py

af6cd9e

cclauss requested changes Sep 28, 2020

View reviewed changes

xcodz-dot and others added 4 commits September 28, 2020 13:12

Update vector3_for_2d_rendering.py

1bad0cc

Update graphics/vector3_for_2d_rendering.py

a098a17

Co-authored-by: Christian Clauss <cclauss@me.com>

Update graphics/vector3_for_2d_rendering.py

b2fee5d

Co-authored-by: Christian Clauss <cclauss@me.com>

Apply suggestions from code review

fe96c7f

Co-authored-by: Christian Clauss <cclauss@me.com>

xcodz-dot added 2 commits September 28, 2020 13:21

Update vector3_for_2d_rendering.py

ff55531

Added A few extra names to __author__ 😄

Update vector3_for_2d_rendering.py

c5f6164

Used Pycharm to fix PEP8 errors, doctest errors

Update vector3_for_2d_rendering.py

f5e9d4e

Added enough doctests

ghost requested a review from cclauss September 28, 2020 08:48

ghost commented Sep 28, 2020

View reviewed changes

Update graphics/vector3_for_2d_rendering.py

44404ef

Co-authored-by: Christian Clauss <cclauss@me.com>

Remove second main()

c5f35b5

cclauss approved these changes Sep 28, 2020

View reviewed changes

cclauss merged commit 1b637ba into TheAlgorithms:master Sep 28, 2020

Uh oh!

Uh oh!

Conversation

ghost commented Sep 27, 2020 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your change:

Checklist:

Uh oh!

TravisBuddy commented Sep 27, 2020

TravisBuddy Request Identifier: 36d37fe0-007b-11eb-a257-6fde496095bb

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost commented Sep 27, 2020

TravisBuddy Request Identifier: 36d37fe0-007b-11eb-a257-6fde496095bb

Uh oh!

ghost commented Sep 27, 2020

Uh oh!

Uh oh!

Uh oh!

TravisBuddy commented Sep 28, 2020

TravisBuddy Request Identifier: d1eeb870-014b-11eb-9be6-0d9634a5fbe7

Uh oh!

TravisBuddy commented Sep 28, 2020

TravisBuddy Request Identifier: 9c7a9f40-0152-11eb-9be6-0d9634a5fbe7

Uh oh!

TravisBuddy commented Sep 28, 2020

TravisBuddy Request Identifier: e07a4e70-0152-11eb-9be6-0d9634a5fbe7

Uh oh!

cclauss commented Sep 28, 2020

Uh oh!

ghost commented Sep 28, 2020

Uh oh!

TravisBuddy commented Sep 28, 2020

TravisBuddy Request Identifier: f6b7dc10-0153-11eb-9be6-0d9634a5fbe7

Uh oh!

ghost commented Sep 28, 2020

Uh oh!

Uh oh!

ghost commented Sep 28, 2020

Uh oh!

Uh oh!

Uh oh!

TravisBuddy commented Sep 28, 2020

TravisBuddy Request Identifier: 42fdb2f0-0156-11eb-9be6-0d9634a5fbe7

Uh oh!

TravisBuddy commented Sep 28, 2020

TravisBuddy Request Identifier: 9d27f970-0156-11eb-9be6-0d9634a5fbe7

Uh oh!

TravisBuddy commented Sep 28, 2020

TravisBuddy Request Identifier: ce7ce940-0156-11eb-9be6-0d9634a5fbe7

Uh oh!

ghost commented Sep 28, 2020

Uh oh!

cclauss left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TravisBuddy commented Sep 28, 2020

TravisBuddy Request Identifier: 66f0a560-015f-11eb-9be6-0d9634a5fbe7

Uh oh!

TravisBuddy commented Sep 28, 2020

TravisBuddy Request Identifier: 07eef0c0-0160-11eb-9be6-0d9634a5fbe7

Uh oh!

ghost commented Sep 28, 2020

Uh oh!

ghost commented Sep 28, 2020

Uh oh!

ghost left a comment • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ghost commented Sep 27, 2020 •

edited by ghost

Loading

ghost left a comment •

edited by ghost

Loading