Skip to content

Created ugly_numbers.py in Python/maths#2366

Merged
cclauss merged 4 commits intoTheAlgorithms:masterfrom
Kush1101:master
Aug 29, 2020
Merged

Created ugly_numbers.py in Python/maths#2366
cclauss merged 4 commits intoTheAlgorithms:masterfrom
Kush1101:master

Conversation

@Kush1101
Copy link
Copy Markdown
Member

@Kush1101 Kush1101 commented Aug 29, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

cclauss
cclauss reviewed Aug 29, 2020
View reviewed changes
Comment thread maths/ugly_numbers.py Outdated
@cclauss
Copy link
Copy Markdown
Member

cclauss commented Aug 29, 2020 •
edited
Loading

I do not need the @cclauss Please review it messages.
I will review PRs when I have the time/inclination. If you are not ready for a review then open your PR in draft mode.

@Kush1101
Copy link
Copy Markdown
Member Author

Kush1101 commented Aug 29, 2020

I do not need the @cclauss Please review it messages.
I will review PRs when I have the time/inclination. If you are not ready for a review then open your PR in draft mode.

Ok sir. I will be careful next time.

cclauss
cclauss reviewed Aug 29, 2020
View reviewed changes
Comment thread maths/ugly_numbers.py
cclauss
cclauss approved these changes Aug 29, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cclauss cclauss merged commit f2f0425 into TheAlgorithms:master Aug 29, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@Kush1101 @stokhos
Created ugly_numbers.py in Python/maths (TheAlgorithms#2366)
f56d503 
* Add files via upload

* Update ugly_numbers.py

* Update ugly_numbers.py

* Update ugly_numbers.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kush1101 @cclauss