Added docstrings and type of parameters - #2341
Closed
SiddhantBobde wants to merge 5 commits into
Closed
Conversation
cclauss
reviewed
Aug 20, 2020
| else: | ||
| return traversal_function(self.root) | ||
|
|
||
| def inorder(self, arr, Node): |
Member
There was a problem hiding this comment.
Type hints are https://docs.python.org/3/library/typing.html
https://docs.python.org/3/library/doctest.html are also missing.
Contributor
Author
There was a problem hiding this comment.
I am adding the type hints
cclauss
reviewed
Aug 20, 2020
| arr.append(Node.value) # appends values of nodes to list arr | ||
| self.inorder(arr, Node.right) | ||
|
|
||
| def find_Kth_Smallest(self, k, Node): |
Member
There was a problem hiding this comment.
Capital letters are not allowed in Python function names.
Member
|
Closing in favor of #2318 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.