Skip to content

Update sum_of_digits.py#2319

Merged
cclauss merged 4 commits into
TheAlgorithms:masterfrom
realDuYuanChao:dev
Aug 16, 2020
Merged

Update sum_of_digits.py#2319
cclauss merged 4 commits into
TheAlgorithms:masterfrom
realDuYuanChao:dev

Conversation

@realDuYuanChao
Copy link
Copy Markdown
Member

@realDuYuanChao realDuYuanChao commented Aug 16, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@realDuYuanChao realDuYuanChao requested a review from cclauss August 16, 2020 14:43
cclauss
cclauss reviewed Aug 16, 2020
View reviewed changes
Comment thread maths/sum_of_digits.py Outdated

if __name__ == "__main__":
print(sum_of_digits(12345)) # ===> 15
main()
Copy link
Copy Markdown
Member

@cclauss cclauss Aug 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this line?

Copy link
Copy Markdown
Member Author

@realDuYuanChao realDuYuanChao Aug 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already test using doctest

cclauss
cclauss requested changes Aug 16, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a timeit (or similar) benchmark to demonstrate which algorithm is faster.

@cclauss
Copy link
Copy Markdown
Member

cclauss commented Aug 16, 2020 •
edited
Loading 

def sum_of_digits_compact(n: int) -> int:
    return sum(int(c) for c in str(n).lstrip("-"))

@realDuYuanChao
Copy link
Copy Markdown
Member Author

realDuYuanChao commented Aug 16, 2020 

def sum_of_digits_compact(n: int) -> int:
    return sum(int(c) for c in str(n).lstrip("-"))

Thanks.

@realDuYuanChao
Copy link
Copy Markdown
Member Author

realDuYuanChao commented Aug 16, 2020 •
edited
Loading

Please review again. I have added benchmark @cclauss

For small_num =  262144 :
> sum_of_digits() 		ans = 19 	time = 0.718940792 seconds
> sum_of_digits_recursion() 	ans = 19 	time = 0.8344459700000001 seconds
> sum_of_digits_compact() 	ans = 19 	time = 1.7255325149999998 seconds

For medium_num =  1125899906842624 :
> sum_of_digits() 		ans = 76 	time = 1.8915360140000002 seconds
> sum_of_digits_recursion() 	ans = 76 	time = 2.0515750509999995 seconds
> sum_of_digits_compact() 	ans = 76 	time = 3.5937960860000002 seconds

For large_num =  1267650600228229401496703205376 :
> sum_of_digits() 		ans = 115 	time = 4.329460676 seconds
> sum_of_digits_recursion() 	ans = 115 	time = 4.349902585000001 seconds
> sum_of_digits_compact() 	ans = 115 	time = 6.016194332999998 seconds

@cclauss cclauss merged commit 34294b5 into TheAlgorithms:master Aug 16, 2020
@realDuYuanChao realDuYuanChao deleted the dev branch August 20, 2020 16:44
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@realDuYuanChao @cclauss @stokhos
Update sum_of_digits.py (TheAlgorithms#2319)
f183a97 
* * support negative number
* add different version

* fixup! Format Python code with psf/black push

* sum(int(c) for c in str(abs(n)))

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@realDuYuanChao @cclauss