project_euler/problem_47/sol1.py by MarkMoretto · Pull Request #2150 · TheAlgorithms/Python

MarkMoretto · 2020-06-24T00:14:27Z

Describe your change:

[ x] Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

[ x] I have read CONTRIBUTING.md.
[ x] This pull request is all my own work -- I have not plagiarized.
[ x] I know that pull requests will not be merged if they fail the automated tests.
[ x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
[ x] All new Python files are placed inside an existing directory.
[ x] All filenames are in all lowercase characters with no spaces or dashes.
[ x] All functions and variable names follow Python naming conventions.
[ x] All function parameters and return values are annotated with Python type hints.
[ x] All functions have doctests that pass the automated testing.
All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Not sure if this should be formatted differently. I'm open to ideas!

Ran code through `black`, `flake8`, and `doctest`. Added some type hints. `doctest` is finicky on sets, so I had to sort and reformat as set to pass those tests.

TravisBuddy · 2020-06-24T00:17:22Z

Hey @MarkMoretto,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 11d27c20-b5b0-11ea-aae7-0b05fcc524af

MarkMoretto · 2020-06-24T01:22:20Z

I don't know how to fix this, lol. I ran it through black, flake8, etc. Seemed to pass, but I'm happy to make any required changes.

Nice. Co-authored-by: Christian Clauss <cclauss@me.com>

TravisBuddy · 2020-06-24T12:38:46Z

Hey @MarkMoretto,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: a434acc0-b617-11ea-aaf6-456b40a357ff

Looks good Co-authored-by: Christian Clauss <cclauss@me.com>

TravisBuddy · 2020-06-24T12:52:17Z

Hey @MarkMoretto,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 87bbf060-b619-11ea-aaf6-456b40a357ff

Okay, this should work. Thank you for the reminder on map(), filter(), reduce(). Co-authored-by: Christian Clauss <cclauss@me.com>

My IDE needs a spellchecker. Or, lighter comment font. Co-authored-by: Christian Clauss <cclauss@me.com>

Co-authored-by: Christian Clauss <cclauss@me.com>

This means that `results = run(N)` should be updated to `results = run(n)`, correct? Co-authored-by: Christian Clauss <cclauss@me.com>

Co-authored-by: Christian Clauss <cclauss@me.com>

TravisBuddy · 2020-06-24T12:59:28Z

Hey @MarkMoretto,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 883103e0-b61a-11ea-aaf6-456b40a357ff

Looks good! Co-authored-by: Christian Clauss <cclauss@me.com>

Co-authored-by: Christian Clauss <cclauss@me.com>

TravisBuddy · 2020-06-24T13:01:13Z

Hey @MarkMoretto,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: c76f0c50-b61a-11ea-aaf6-456b40a357ff

TravisBuddy · 2020-06-24T13:02:34Z

Hey @MarkMoretto,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: f76aadb0-b61a-11ea-aaf6-456b40a357ff

Works for me! I spent way too much time getting this to pass doctest, so any improvement is welcome. Co-authored-by: Christian Clauss <cclauss@me.com>

TravisBuddy · 2020-06-24T13:10:07Z

Hey @MarkMoretto,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 050e3c60-b61c-11ea-aaf6-456b40a357ff

Added some suggested changes from the pull request: * Updated tests outputs in `unique_prime_factors` function. * Changed `@lru_cache(maxsize=5)` to `@lru_cache(maxsize=None)` * Removed duplicate `return` line in `equality` function * Changed `i` to `base` in run function. * Added some commentary to `run()` function. * Replaced `group = list(map(lambda x: base + x, [i for i in range(n)]))` with `group = [base + i for i in range(n)]`

TravisBuddy · 2020-06-24T13:25:50Z

Hey @MarkMoretto,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 36f32540-b61e-11ea-aaf6-456b40a357ff

TravisBuddy · 2020-06-24T14:26:50Z

Hey @MarkMoretto,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: bcae1840-b626-11ea-aaf6-456b40a357ff

TravisBuddy · 2020-06-24T15:13:45Z

Hey @MarkMoretto,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 4a7e0da0-b62d-11ea-aaf6-456b40a357ff

TravisBuddy · 2020-06-24T17:00:32Z

Hey @MarkMoretto,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 35627780-b63c-11ea-aaf6-456b40a357ff

TravisBuddy · 2020-06-24T17:43:51Z

Hey @MarkMoretto,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 43155630-b642-11ea-aaf6-456b40a357ff

TravisBuddy · 2020-06-24T17:49:33Z

Hey @MarkMoretto,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 0eda40f0-b643-11ea-aaf6-456b40a357ff

TravisBuddy · 2020-06-24T17:56:09Z

Hey @MarkMoretto,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: fa25d970-b643-11ea-aaf6-456b40a357ff

Looks good

* Create __init__.py * Initial commit Not sure if this should be formatted differently. I'm open to ideas! * Completing testing/updates Ran code through `black`, `flake8`, and `doctest`. Added some type hints. `doctest` is finicky on sets, so I had to sort and reformat as set to pass those tests. * Update project_euler/problem_47/sol1.py Nice. Co-authored-by: Christian Clauss <cclauss@me.com> * Update project_euler/problem_47/sol1.py Looks good Co-authored-by: Christian Clauss <cclauss@me.com> * Update project_euler/problem_47/sol1.py Okay, this should work. Thank you for the reminder on map(), filter(), reduce(). Co-authored-by: Christian Clauss <cclauss@me.com> * Update project_euler/problem_47/sol1.py My IDE needs a spellchecker. Or, lighter comment font. Co-authored-by: Christian Clauss <cclauss@me.com> * Update project_euler/problem_47/sol1.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update project_euler/problem_47/sol1.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update project_euler/problem_47/sol1.py This means that `results = run(N)` should be updated to `results = run(n)`, correct? Co-authored-by: Christian Clauss <cclauss@me.com> * Update project_euler/problem_47/sol1.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update project_euler/problem_47/sol1.py Looks good! Co-authored-by: Christian Clauss <cclauss@me.com> * Update project_euler/problem_47/sol1.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update project_euler/problem_47/sol1.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update project_euler/problem_47/sol1.py Works for me! I spent way too much time getting this to pass doctest, so any improvement is welcome. Co-authored-by: Christian Clauss <cclauss@me.com> * Update sol1.py Added some suggested changes from the pull request: * Updated tests outputs in `unique_prime_factors` function. * Changed `@lru_cache(maxsize=5)` to `@lru_cache(maxsize=None)` * Removed duplicate `return` line in `equality` function * Changed `i` to `base` in run function. * Added some commentary to `run()` function. * Replaced `group = list(map(lambda x: base + x, [i for i in range(n)]))` with `group = [base + i for i in range(n)]` * Update sol1.py * Trailing whitespace * Update sol1.py * Update __init__.py * Update sol1.py * Update __init__.py Co-authored-by: Christian Clauss <cclauss@me.com>

MarkMoretto added 3 commits June 23, 2020 19:36

Create __init__.py

f225be4

Initial commit

388bec4

Not sure if this should be formatted differently. I'm open to ideas!

Completing testing/updates

71b432e

Ran code through `black`, `flake8`, and `doctest`. Added some type hints. `doctest` is finicky on sets, so I had to sort and reformat as set to pass those tests.

cclauss previously requested changes Jun 24, 2020

View reviewed changes

Update project_euler/problem_47/sol1.py

61cbe18

Nice. Co-authored-by: Christian Clauss <cclauss@me.com>

Update project_euler/problem_47/sol1.py

ce4d670

Looks good Co-authored-by: Christian Clauss <cclauss@me.com>

MarkMoretto and others added 6 commits June 24, 2020 08:55

Update project_euler/problem_47/sol1.py

2449898

Okay, this should work. Thank you for the reminder on map(), filter(), reduce(). Co-authored-by: Christian Clauss <cclauss@me.com>

Update project_euler/problem_47/sol1.py

0947926

My IDE needs a spellchecker. Or, lighter comment font. Co-authored-by: Christian Clauss <cclauss@me.com>

Update project_euler/problem_47/sol1.py

8a4cdf9

Co-authored-by: Christian Clauss <cclauss@me.com>

Update project_euler/problem_47/sol1.py

3d10e34

Co-authored-by: Christian Clauss <cclauss@me.com>

Update project_euler/problem_47/sol1.py

e96cb25

This means that `results = run(N)` should be updated to `results = run(n)`, correct? Co-authored-by: Christian Clauss <cclauss@me.com>

Update project_euler/problem_47/sol1.py

0bb6352

Co-authored-by: Christian Clauss <cclauss@me.com>

MarkMoretto and others added 3 commits June 24, 2020 08:59

Update project_euler/problem_47/sol1.py

c3d3887

Looks good! Co-authored-by: Christian Clauss <cclauss@me.com>

Update project_euler/problem_47/sol1.py

97bcaaa

Co-authored-by: Christian Clauss <cclauss@me.com>

Update project_euler/problem_47/sol1.py

1c2ef0b

Co-authored-by: Christian Clauss <cclauss@me.com>

Update project_euler/problem_47/sol1.py

3cdc62c

Works for me! I spent way too much time getting this to pass doctest, so any improvement is welcome. Co-authored-by: Christian Clauss <cclauss@me.com>

Update sol1.py

def54a9

Trailing whitespace

9603f48

Update sol1.py

7443e13

Update __init__.py

b148bec

Update sol1.py

3b7e0b0

Update __init__.py

fe30329

cclauss changed the title ~~Patch 2~~ project_euler/problem_47/sol1.py Jun 25, 2020

cclauss approved these changes Jun 25, 2020

View reviewed changes

cclauss merged commit 3d41723 into TheAlgorithms:master Jun 25, 2020

Uh oh!

Conversation

MarkMoretto commented Jun 24, 2020

Describe your change:

Checklist:

Uh oh!

TravisBuddy commented Jun 24, 2020

TravisBuddy Request Identifier: 11d27c20-b5b0-11ea-aae7-0b05fcc524af

Uh oh!

MarkMoretto commented Jun 24, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TravisBuddy commented Jun 24, 2020

TravisBuddy Request Identifier: a434acc0-b617-11ea-aaf6-456b40a357ff

Uh oh!

TravisBuddy commented Jun 24, 2020

TravisBuddy Request Identifier: 87bbf060-b619-11ea-aaf6-456b40a357ff

Uh oh!

TravisBuddy commented Jun 24, 2020

TravisBuddy Request Identifier: 883103e0-b61a-11ea-aaf6-456b40a357ff

Uh oh!

TravisBuddy commented Jun 24, 2020

TravisBuddy Request Identifier: c76f0c50-b61a-11ea-aaf6-456b40a357ff

Uh oh!

TravisBuddy commented Jun 24, 2020

TravisBuddy Request Identifier: f76aadb0-b61a-11ea-aaf6-456b40a357ff

Uh oh!

TravisBuddy commented Jun 24, 2020

TravisBuddy Request Identifier: 050e3c60-b61c-11ea-aaf6-456b40a357ff

Uh oh!

TravisBuddy commented Jun 24, 2020

TravisBuddy Request Identifier: 36f32540-b61e-11ea-aaf6-456b40a357ff

Uh oh!

TravisBuddy commented Jun 24, 2020

TravisBuddy Request Identifier: bcae1840-b626-11ea-aaf6-456b40a357ff

Uh oh!

TravisBuddy commented Jun 24, 2020

TravisBuddy Request Identifier: 4a7e0da0-b62d-11ea-aaf6-456b40a357ff

Uh oh!

TravisBuddy commented Jun 24, 2020

TravisBuddy Request Identifier: 35627780-b63c-11ea-aaf6-456b40a357ff

Uh oh!

TravisBuddy commented Jun 24, 2020

TravisBuddy Request Identifier: 43155630-b642-11ea-aaf6-456b40a357ff

Uh oh!

TravisBuddy commented Jun 24, 2020

TravisBuddy Request Identifier: 0eda40f0-b643-11ea-aaf6-456b40a357ff

Uh oh!

TravisBuddy commented Jun 24, 2020

TravisBuddy Request Identifier: fa25d970-b643-11ea-aaf6-456b40a357ff

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants