create sum_of_digits.py#2065
Merged
Merged
Conversation
create sum_of_digits.py to find the sum of digits of a number digit_sum(12345) ---> 15 digit_sum(12345) ---> 10
cclauss
requested changes
Jun 2, 2020
| """ | ||
| res = 0 | ||
| while n > 0: | ||
| res += n % 10 |
Member
There was a problem hiding this comment.
Could we optimize using Python builtin https://docs.python.org/3/library/functions.html#divmod ?
Contributor
Author
There was a problem hiding this comment.
Yeah, divmod() method would be faster than mod operator. But for small values, there is not much difference. Everytime, we mod a number with 10 until it becomes 0 will not have much effect on the running time I guess.
Member
There was a problem hiding this comment.
def digits(n):
while n:
n, digit = divmod(n, 10)
yield digit
print(sum(digits(12345)))
Contributor
Author
There was a problem hiding this comment.
Yeah, that's the digit sum function using divmod()
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
approved these changes
Jun 2, 2020
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* create sum_of_digits.py create sum_of_digits.py to find the sum of digits of a number digit_sum(12345) ---> 15 digit_sum(12345) ---> 10 * Update sum_of_digits.py * Update maths/sum_of_digits.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update maths/sum_of_digits.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update sum_of_digits.py Co-authored-by: Christian Clauss <cclauss@me.com>
GlennCheng
pushed a commit
to GlennCheng/Python
that referenced
this pull request
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create sum_of_digits.py to find the sum of digits of a number
digit_sum(12345) ---> 15
digit_sum(1234) ---> 10